[WIP][Perf] Cache PropertyChanged/ChangingEventArgs on BindableProperty#34136
Draft
simonrozsival wants to merge 2 commits intonet11.0from
Draft
[WIP][Perf] Cache PropertyChanged/ChangingEventArgs on BindableProperty#34136simonrozsival wants to merge 2 commits intonet11.0from
simonrozsival wants to merge 2 commits intonet11.0from
Conversation
…bleProperty Fixes #34092 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
simonrozsival
added
perf/general
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Feb 19, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Fixes #34092
Description
Every
SetValuecall allocates newPropertyChangedEventArgsandPropertyChangingEventArgsobjects. SinceBindableProperty.PropertyNameis immutable, these are now cached on theBindablePropertyinstance via lazy??=fields.Also handles
Element.OnPropertyChangedwhich creates a secondPropertyChangedEventArgsfor effects — reuses the cached args when the call originates from a BindableProperty set.Files changed
BindableProperty.cs— cached fields + getter methodsBindableObject.cs— internal overloads + updated call sitesElement.cs—_currentPropertyBeingSetto reuse args for effects