Skip to content

Resolve ide0040, ide0051, ide0052, ide0350 warnings#11740

Merged
YuliiaKovalova merged 2 commits intomainfrom
ResolveCompilerWarningsFrom10SDK
Apr 22, 2025
Merged

Resolve ide0040, ide0051, ide0052, ide0350 warnings#11740
YuliiaKovalova merged 2 commits intomainfrom
ResolveCompilerWarningsFrom10SDK

Conversation

@ViktorHofer
Copy link
Copy Markdown
Member

@ViktorHofer ViktorHofer commented Apr 17, 2025 •
edited
Loading

These are showing up when building with a recent .NET 10 SDK. This allows us to remove the warnAsError=false flag in the VMR when building msbuild

Review with hide whitespaces toggled one:

image

Fixes #

Context

Changes Made

Testing

Notes

@ViktorHofer
Resolve ide0040, ide0051, ide0052, ide0350 warnings
443d065 
These are showing up when building with a recent .NET 10 SDK.
This allows us to remove the warnAsError=false flag in the VMR when building msbuild
@ViktorHofer
fix the debug build
edb8b5a
@ViktorHofer ViktorHofer marked this pull request as ready for review April 17, 2025 13:54
Copilot AI review requested due to automatic review settings April 17, 2025 13:54
Copilot AI reviewed Apr 17, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 34 out of 34 changed files in this pull request and generated no comments.

@ViktorHofer ViktorHofer requested a review from a team April 17, 2025 15:15
@ViktorHofer
Copy link
Copy Markdown
Member Author

ViktorHofer commented Apr 17, 2025

@dotnet/kitten PTAL

@ViktorHofer ViktorHofer mentioned this pull request Apr 18, 2025
Merged
@ViktorHofer
Copy link
Copy Markdown
Member Author

ViktorHofer commented Apr 22, 2025

Can you please also merge this PR? I don't have permissions to do so.

@YuliiaKovalova YuliiaKovalova merged commit d5ac662 into main Apr 22, 2025
10 checks passed
@YuliiaKovalova YuliiaKovalova deleted the ResolveCompilerWarningsFrom10SDK branch April 22, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@AR-May AR-May AR-May approved these changes

@YuliiaKovalova YuliiaKovalova YuliiaKovalova approved these changes

@JanProvaznik JanProvaznik Awaiting requested review from JanProvaznik

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ViktorHofer @AR-May @YuliiaKovalova