Skip to content

Validate IReminderTable during startup if any grains implement IRemindable#4280

Closed
ReubenBond wants to merge 3 commits intodotnet:masterfrom
ReubenBond:validate-reminders
Closed

Validate IReminderTable during startup if any grains implement IRemindable#4280
ReubenBond wants to merge 3 commits intodotnet:masterfrom
ReubenBond:validate-reminders

Conversation

@ReubenBond
Copy link
Copy Markdown
Member

Fixes #4278

This assumes that if the user adds some grain which implements IRemindable, then that means they intend to use reminders. That assumption might not be true, but maybe we'll decide it's better to err on the side of caution.

An alternative is late checking, like so:
image

I'm happy with either and looking for input.

@ReubenBond ReubenBond added this to the 2.0.0 milestone Mar 22, 2018
@ReubenBond
Copy link
Copy Markdown
Member Author

@dotnet-bot test functional

UnitTests.ActivationsLifeCycleTests.DeactivateOnIdleTests.DeactivateOnIdle_NonExistentActivation_1
MESSAGE:
Orleans.Runtime.OrleansLifecycleCanceledException : Lifecycle start canceled due to errors at stage 20000\r\n---- Orleans.Runtime.OrleansMessageRejectionException : Forwarding failed: tried to forward message NewPlacement Request S127.0.0.1:27756:259412658stg/0/00000000@S00000000->S127.0.0.1:27756:259412658grn/FCB3F509/00003039@a067ac8a #13: for 0 times after Duplicate activation to invalid activation. Rejecting now.

@ReubenBond
Copy link
Copy Markdown
Member Author

ReubenBond commented Mar 22, 2018

Maybe we should table this approach and go for the lazy approach in the diff image above.

EDIT: opened #4287

@sergeybykov
Copy link
Copy Markdown
Contributor

Let's close this one for now. The concern is that this might be too aggressive, and lead to unintended consequences in corner cases.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants