fix warning CA2211 in AzureClient#6
Merged
gabikliot merged 1 commit intodotnet:masterfrom Jan 24, 2015
zerhacken:dev/warning
Merged
fix warning CA2211 in AzureClient#6gabikliot merged 1 commit intodotnet:masterfrom zerhacken:dev/warning
gabikliot merged 1 commit intodotnet:masterfrom
zerhacken:dev/warning
Conversation
Changed fields MaxRetries and TimeSpan to read-only.
jdom
pushed a commit
to jdom/orleans
that referenced
this pull request
Sep 14, 2016
Change initialization of OutsideRuntimeClient to start with a handshake client ID, and update it with cluster ID received from gateway.
ReubenBond
pushed a commit
that referenced
this pull request
Dec 20, 2016
* Implement Grain Services which are a partitioned SystemTarget service. Can invoke a Grain Service with a test. Added Grain Service Configuration Tests reporting: Exception thrown: 'Orleans.CodeGenerator.CodeGenerationException' in OrleansCodeGenerator.dll Additional information: (1,18913): error CS0122: 'ITestHooksSystemTarget' is inaccessible due to its protection level Resolved GrainService GrainId, InsideRuntimeClient using ReminderRegistr SystemTarget public, GrainServiceClient used SystemTarget is now public, removed GrainService analog, now contains just GrainService logic GrainServiceClient is used to locate the IReminderService Cannot capture the correct Reminder GrainId (GrainClassData not available)? SystemTarget public, GrainServiceClient used Initial stab at implementing a partitioned system service. From @sergeybykov comments, attempted the below: --- I see at least two potential ways, likely complementary, to expose such functionality to application code. 1) Partitioned system service. Essentially a generalized version of the Reminder service, but with an application system target class instead of LocalReminderService, e.g. GrainService, and a corresponding equivalent to ReminderRegistry proxy class, e.g. GrainServiceClient. We only create a single LocalReminderService system target per silo today, but it shouldn't be too difficult to make that number configurable. In this approach, callers are completely oblivious to partitioning and routing, and it's the responsibility of the GrainService to react to repartitioning events and changes to the ring range it owns. * Added an explicit method NewGrainServiceKey to UniqueKey instead of reusing the more general NewKey directly. * Added type name to log statements and as the logger name. * Reverted RegisterSystemTarget back to internal. * Eliminated a warning about deprecated Consul method. * Added XML commenst and tweaked a few methods to eliminate build warnings. * Tweaks to make code .NET Core compatible. * Support dependency injection in GrainServices (#6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed fields MaxRetries and TimeSpan to read-only.