Redis durablejobs storage by jaironalves · Pull Request #9823 · dotnet/orleans

jaironalves · 2025-11-27T01:30:43Z

Microsoft Reviewers: Open in CodeFlow

Co-authored-by: jaironalves <29267813+jaironalves@users.noreply.github.com>

…cture Co-authored-by: jaironalves <29267813+jaironalves@users.noreply.github.com>

Co-authored-by: jaironalves <29267813+jaironalves@users.noreply.github.com>

…evert NuGet.Config Co-authored-by: jaironalves <29267813+jaironalves@users.noreply.github.com>

…Extensions Co-authored-by: jaironalves <29267813+jaironalves@users.noreply.github.com>

…led) Co-authored-by: jaironalves <29267813+jaironalves@users.noreply.github.com>

Co-authored-by: jaironalves <29267813+jaironalves@users.noreply.github.com>

…onContext Co-authored-by: jaironalves <29267813+jaironalves@users.noreply.github.com>

…Azure implementation Co-authored-by: jaironalves <29267813+jaironalves@users.noreply.github.com>

… implementation Co-authored-by: jaironalves <29267813+jaironalves@users.noreply.github.com>

…cript Co-authored-by: jaironalves <29267813+jaironalves@users.noreply.github.com>

Co-authored-by: jaironalves <29267813+jaironalves@users.noreply.github.com>

- Create RedisJobShardManager.Log.cs with partial methods using LoggerMessage attributes - Update RedisJobShardManager.cs to use the new partial log methods - Follow the same pattern used in AzureStorageJobShardManager and RedisJobShard Co-authored-by: jaironalves <29267813+jaironalves@users.noreply.github.com>

…urableJobs package Co-authored-by: jaironalves <29267813+jaironalves@users.noreply.github.com>

- Fix TaskCompletionSource type inconsistency (use non-generic version) - Use consistent ConfigureAwait pattern with Azure implementation - Fix batch collection logic to use TryPeek instead of TryRead/TryWrite - Initialize MetadataVersion from metadata dictionary in constructor - Add local function for batch collection consistency with Azure Co-authored-by: jaironalves <29267813+jaironalves@users.noreply.github.com>

Critical fix: Use expectedVersion instead of MetadataVersion when calculating newVersion in ExecuteUpdateMetadataAsync to prevent race conditions and ensure proper CAS semantics. Add comprehensive review document detailing all findings. Co-authored-by: jaironalves <29267813+jaironalves@users.noreply.github.com>

Co-authored-by: jaironalves <29267813+jaironalves@users.noreply.github.com>

The review findings have been documented in the PR description instead. Co-authored-by: jaironalves <29267813+jaironalves@users.noreply.github.com>

…bs Redis Co-authored-by: jaironalves <29267813+jaironalves@users.noreply.github.com>

Co-authored-by: jaironalves <29267813+jaironalves@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated no new comments.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Pull request overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.

src/Redis/Orleans.DurableJobs.Redis/Hosting/RedisJobShardOptionsValidator.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Pull request overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated 3 comments.

src/Redis/Orleans.DurableJobs.Redis/RedisJobShard.cs

src/Redis/Orleans.DurableJobs.Redis/README.md

test/Extensions/Tester.Redis/DurableJobs/RedisJobShardManagerTestFixture.cs

…ions

Copilot

Pull request overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated 2 comments.

src/Redis/Orleans.DurableJobs.Redis/Hosting/RedisDurableJobsExtensions.cs

src/Redis/Orleans.DurableJobs.Redis/JobOperation.cs

Copilot

Pull request overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated 3 comments.

src/Redis/Orleans.DurableJobs.Redis/RedisJobShard.cs

src/Redis/Orleans.DurableJobs.Redis/RedisOperationsManager.cs

test/Extensions/Tester.Redis/DurableJobs/RedisJobShardManagerTests.cs

jaironalves and others added 18 commits November 21, 2025 08:57

feat: 2 versions - Need Refactor

7b93b58

feat: Redis Durable Jobs

b98ac4e

Initial analysis of Redis DurableJobs package

bcb6316

Co-authored-by: jaironalves <29267813+jaironalves@users.noreply.github.com>

Make Redis DurableJobs production-ready with proper hosting infrastru…

42f12ed

…cture Co-authored-by: jaironalves <29267813+jaironalves@users.noreply.github.com>

Add Redis DurableJobs tests following Azure test patterns

308c6ad

Co-authored-by: jaironalves <29267813+jaironalves@users.noreply.github.com>

Update RedisJobShardOptions to use ConfigurationOptions pattern and r…

73fb231

…evert NuGet.Config Co-authored-by: jaironalves <29267813+jaironalves@users.noreply.github.com>

Add missing using Orleans.Configuration namespace in RedisDurableJobs…

e98c0ba

…Extensions Co-authored-by: jaironalves <29267813+jaironalves@users.noreply.github.com>

Remove nullable type annotations from test fixture (nullable not enab…

451a6e5

…led) Co-authored-by: jaironalves <29267813+jaironalves@users.noreply.github.com>

Fix StreamRange count parameter - remove invalid 0 value

15d9134

Co-authored-by: jaironalves <29267813+jaironalves@users.noreply.github.com>

Remove unnecessary note comment from StreamRange call

833aa43

Co-authored-by: jaironalves <29267813+jaironalves@users.noreply.github.com>

Add Encode method to RedisStreamJsonSerializer and use JobOperationJs…

4316469

…onContext Co-authored-by: jaironalves <29267813+jaironalves@users.noreply.github.com>

Fix UnregisterShardAsync to delete shard when job count is zero like …

c358bdf

…Azure implementation Co-authored-by: jaironalves <29267813+jaironalves@users.noreply.github.com>

Set Metadata property in RedisJobShard constructor to sync with Azure…

e4f62f8

… implementation Co-authored-by: jaironalves <29267813+jaironalves@users.noreply.github.com>

Fix CreateShardAsync to save all metadata fields using cjson in Lua s…

b616734

…cript Co-authored-by: jaironalves <29267813+jaironalves@users.noreply.github.com>

Remove new Metadata property - use base class property instead

b730c36

Co-authored-by: jaironalves <29267813+jaironalves@users.noreply.github.com>

feat: Revert lines projects positions

088b209

Merge branch 'dotnet:main' into feature/redis-durablejobs

c6c3dda

This comment was marked as resolved.

Sign in to view

Copilot AI and others added 10 commits December 3, 2025 22:58

Remove unused log methods with Azure-specific references from Redis D…

5f7051d

…urableJobs package Co-authored-by: jaironalves <29267813+jaironalves@users.noreply.github.com>

Add Portuguese summary of Redis DurableJobs review

a4e925a

Co-authored-by: jaironalves <29267813+jaironalves@users.noreply.github.com>

Remove review markdown files as requested

61a989e

The review findings have been documented in the PR description instead. Co-authored-by: jaironalves <29267813+jaironalves@users.noreply.github.com>

Centralize Redis operations into RedisOperationsManager for DurableJo…

7ee6d6d

…bs Redis Co-authored-by: jaironalves <29267813+jaironalves@users.noreply.github.com>

Fix method signature in TryTakeOwnershipAsync call

6c8f389

Co-authored-by: jaironalves <29267813+jaironalves@users.noreply.github.com>

Add clarifying comments for design decisions

1fbda00

Co-authored-by: jaironalves <29267813+jaironalves@users.noreply.github.com>

feat: Fix Encode Return Type

e410213

feat: Review unused var

5856f47

jaironalves marked this pull request as ready for review December 6, 2025 17:48

jaironalves requested a review from Copilot December 6, 2025 18:43

Copilot started reviewing on behalf of jaironalves December 6, 2025 18:43 View session

Copilot AI reviewed Dec 6, 2025

View reviewed changes

jaironalves requested review from Copilot December 6, 2025 19:20

Copilot started reviewing on behalf of jaironalves December 6, 2025 19:20 View session

Copilot AI reviewed Dec 6, 2025

View reviewed changes

src/Redis/Orleans.DurableJobs.Redis/Hosting/RedisJobShardOptionsValidator.cs Show resolved Hide resolved

Validate CreateMultiplexer option

978b9b2

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI reviewed Dec 6, 2025

View reviewed changes

jaironalves requested a review from Copilot December 6, 2025 20:44

Copilot started reviewing on behalf of jaironalves December 6, 2025 20:45 View session

Copilot AI reviewed Dec 6, 2025

View reviewed changes

src/Redis/Orleans.DurableJobs.Redis/RedisJobShard.cs Show resolved Hide resolved

src/Redis/Orleans.DurableJobs.Redis/README.md Outdated Show resolved Hide resolved

test/Extensions/Tester.Redis/DurableJobs/RedisJobShardManagerTestFixture.cs Outdated Show resolved Hide resolved

jaironalves added 2 commits December 7, 2025 11:58

feat: Copilot Review

c369cc2

fix: Move redis checker to constructor - Same other redis implementat…

5f49aec

…ions

jaironalves requested a review from Copilot December 7, 2025 17:23

Copilot started reviewing on behalf of jaironalves December 7, 2025 17:24 View session

Copilot AI reviewed Dec 7, 2025

View reviewed changes

src/Redis/Orleans.DurableJobs.Redis/Hosting/RedisDurableJobsExtensions.cs Outdated Show resolved Hide resolved

src/Redis/Orleans.DurableJobs.Redis/JobOperation.cs Show resolved Hide resolved

feat: Extensions remove duplicates

4ecab6b

jaironalves requested a review from Copilot December 7, 2025 23:09

Copilot started reviewing on behalf of jaironalves December 7, 2025 23:09 View session

Copilot AI reviewed Dec 7, 2025

View reviewed changes

src/Redis/Orleans.DurableJobs.Redis/RedisJobShard.cs Outdated Show resolved Hide resolved

src/Redis/Orleans.DurableJobs.Redis/RedisOperationsManager.cs Outdated Show resolved Hide resolved

test/Extensions/Tester.Redis/DurableJobs/RedisJobShardManagerTests.cs Outdated Show resolved Hide resolved

jaironalves added 2 commits December 7, 2025 20:31

feat: Copilot Review

f391104

feat: Key prefix redis options

671c9a9

jaironalves changed the title ~~Add Redis durablejobs Implementation~~ Redis durablejobs storage Feb 1, 2026

feat: Merge main

841de00

jaironalves force-pushed the feature/redis-durablejobs branch from 5f5864d to 841de00 Compare March 28, 2026 20:09

jaironalves added 3 commits March 28, 2026 17:49

Update test project to match the new project layout

e9f0de9

Add internal visible

24c23ad

Remove properties

72ce1f9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Redis durablejobs storage#9823

Redis durablejobs storage#9823
jaironalves wants to merge 40 commits intodotnet:mainfrom
jaironalves:feature/redis-durablejobs

jaironalves commented Nov 27, 2025 •

edited by dotnet-policy-service bot

Loading

Uh oh!

This comment was marked as resolved.

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

jaironalves commented Nov 27, 2025 • edited by dotnet-policy-service bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Microsoft Reviewers: Open in CodeFlow

Uh oh!

This comment was marked as resolved.

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jaironalves commented Nov 27, 2025 •

edited by dotnet-policy-service bot

Loading