-
Notifications
You must be signed in to change notification settings - Fork 280
Add create test suite command to gc infra. #4803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add create test suite command to gc infra. #4803
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new command to create a test suite for the Reliability Framework within the GC Infrastructure. Key changes include:
- Registering a new command in Program.cs.
- Adding multiple configuration and script files for reliability tests.
- Implementing the ReliabilityFrameworkTestCreateTestsSuiteCommand and supporting utilities and configuration parsing.
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
Program.cs | Added using statement and registration for the new reliability test command. |
GC.Infrastructure.csproj | Added new non-code files related to the Reliability Framework tests. |
.config, TestingScript..txt | Added XML and script files for different test configurations and environments. |
ReliabilityFrameworkTestCreateTestSuiteCommand.cs | Implementation of the new test suite creation command. |
Utilities.cs | Minor refactoring to file and directory copying functions. |
Configuration and Test Suite Creator files | Added parsing and asset generation functions for the test suite. |
ReliabilityFrameworkTestCreateSuite.yaml | New YAML configuration file for the test suite. |
Comments suppressed due to low confidence (1)
src/benchmarks/gc/GC.Infrastructure/GC.Infrastructure/Commands/ReliabilityFrameworkTest/ReliabilityFrameworkTestCreateTestSuiteCommand.cs:10
- The class name 'ReliabilityFrameworkTestCreateTestsSuiteCommand' contains an extra 's' compared to the file name 'ReliabilityFrameworkTestCreateTestSuiteCommand.cs'. Consider renaming the class to 'ReliabilityFrameworkTestCreateTestSuiteCommand' for consistency.
public sealed class ReliabilityFrameworkTestCreateTestsSuiteCommand :
...re/GC.Infrastructure/Commands/RunCommand/BaseSuite/ReliabilityFramework/TestingScript.sh.txt
Show resolved
Hide resolved
src/benchmarks/gc/GC.Infrastructure/GC.Infrastructure/Program.cs
Outdated
Show resolved
Hide resolved
...astructure/GC.Infrastructure.Core/Configurations/ReliabilityFrameworkTest.CreateTestSuite.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - let's address the remaining comments in subsequent PRs.
Add ReliabilityFrameworkTestCreateTestsSuiteCommand to GC Infra.
a. Adding a new command(
"rftest-createtestsuite"
) in Program.cs.b. Adding multiple configuration and script files for reliability tests.
c. Implementing the ReliabilityFrameworkTestCreateTestsSuiteCommand and supporting utilities and configuration parsing.