Skip to content

Conversation

WangyangZhou90
Copy link
Contributor

@WangyangZhou90 WangyangZhou90 commented Mar 28, 2025

Add ReliabilityFrameworkTestCreateTestsSuiteCommand to GC Infra.
a. Adding a new command("rftest-createtestsuite") in Program.cs.
b. Adding multiple configuration and script files for reliability tests.
c. Implementing the ReliabilityFrameworkTestCreateTestsSuiteCommand and supporting utilities and configuration parsing.

@shimingsg shimingsg requested a review from Copilot May 22, 2025 02:59
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new command to create a test suite for the Reliability Framework within the GC Infrastructure. Key changes include:

  • Registering a new command in Program.cs.
  • Adding multiple configuration and script files for reliability tests.
  • Implementing the ReliabilityFrameworkTestCreateTestsSuiteCommand and supporting utilities and configuration parsing.

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Program.cs Added using statement and registration for the new reliability test command.
GC.Infrastructure.csproj Added new non-code files related to the Reliability Framework tests.
.config, TestingScript..txt Added XML and script files for different test configurations and environments.
ReliabilityFrameworkTestCreateTestSuiteCommand.cs Implementation of the new test suite creation command.
Utilities.cs Minor refactoring to file and directory copying functions.
Configuration and Test Suite Creator files Added parsing and asset generation functions for the test suite.
ReliabilityFrameworkTestCreateSuite.yaml New YAML configuration file for the test suite.
Comments suppressed due to low confidence (1)

src/benchmarks/gc/GC.Infrastructure/GC.Infrastructure/Commands/ReliabilityFrameworkTest/ReliabilityFrameworkTestCreateTestSuiteCommand.cs:10

  • The class name 'ReliabilityFrameworkTestCreateTestsSuiteCommand' contains an extra 's' compared to the file name 'ReliabilityFrameworkTestCreateTestSuiteCommand.cs'. Consider renaming the class to 'ReliabilityFrameworkTestCreateTestSuiteCommand' for consistency.
public sealed class ReliabilityFrameworkTestCreateTestsSuiteCommand :

mrsharm
mrsharm previously approved these changes Aug 27, 2025
Copy link
Member

@mrsharm mrsharm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - let's address the remaining comments in subsequent PRs.

@mrsharm mrsharm merged commit 7dced90 into dotnet:main Aug 28, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants