Fix Sve benchmark warning and config #5012
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Suppress Sve experimental warning in project config * Remove redundant Sve.IsSupported checks as it is already checked when in the benchmark filter config.
|
@dotnet/arm64-contrib @SwapnilGaikwad |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppress Sve experimental warning in project config.
I am not sure if it is possible to suppress warning on specific files instead of the whole project. However, since
SYSLIB5003is specific to the SVE experimental API, it should only affect the benchmarks inside thesrc/benchmarks/micro/svedirectory.Remove redundant Sve.IsSupported checks as it is already checked in the benchmark filter config. SVE benchmarks will be filtered out when executing on non-SVE machines.