Skip to content

Specify PrivateAssets="all" #9328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Specify PrivateAssets="all" #9328

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/imports/HostAgnostic.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<!-- Path Property: PkgMicrosoft_DiaSymReader_Pdb2Pdb -->
<PackageReference Include="Microsoft.DiaSymReader.Pdb2Pdb" ExcludeAssets="all" GeneratePathProperty="true" />
<PackageReference Include="Microsoft.DotNet.XliffTasks" PrivateAssets="all" />
<PackageReference Include="Microsoft.Net.Compilers.Toolset" />
<PackageReference Include="Microsoft.Net.Compilers.Toolset" PrivateAssets="all" />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should re-evaluate whether or not we need this package to begin with. It exists to give you a way to pick up a different version of the compiler than you get with the SDK, and this can be useful if you are stuck with an SDK with a compiler bug or want to use a compiler feature not available through the SDK. However, we don't use lock ourselves to a particular SDK with global.json and frequently have pre-release SDK builds on our systems. As such, the compiler we've chosen here will often be older than the SDK we're using, and sometimes newer, but we're not controlling the relationship between them in any meaningful way.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that this package lets us dogfoods new compiler bits in a way that works for all developers who might open this repo. If we leave it to the SDK, then developers on older SDKs won't be able to compile.

<!--
The SourceLink package depends on the repo provider used.
https://github.com/dotnet/sourcelink#using-source-link-in-net-projects
Expand Down