Improve perf of accessing configured values in tree, particularly during solution load #9686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dotnet#2707 Lifeng reported that calling `GetActiveConfiguredProjectExports` on the base class was taking 0.5 seconds of CPU while loading Roslyn.sln. This change uses `IActiveConfiguredValue<>` to cache the instance, to improve performance while building dependencies trees across the solution during solution load.
The IDE suggests this.
This style is uncommon in this repo, so document that/why it's needed here.
This caches the configured value in the ImportTreeProvider, as recently done for the DependenciesTreeProvider.
drewnoakes
added
the
Tenet-Performance
drewnoakes
added
Feature-Dependency-Node
adamint
approved these changes
Jun 23, 2025
| } | ||
| } | ||
|
|
||
| // NOTE this interface is needed to work around accessiblity issues when making MyConfiguredProjectExports non-private |
Member
There was a problem hiding this comment.
could you be more specific in this comment?
Member
Author
There was a problem hiding this comment.
Honestly this one had me stumped. The compiler claimed there was a visibility issue (CS0060), and the issue couldn't be suppressed. Something to do with the base type being protected internal yet in a different assembly, maybe. I was confused enough to even view (and edit) the docs for that diagnostic. So, I don't have much more context to add here. If you remove the interface and try to export the concrete type, you'll see the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2707
Lifeng reported that calling
GetActiveConfiguredProjectExportson the base class was taking 0.5 seconds of CPU while loading Roslyn.sln.This change uses
IActiveConfiguredValue<>to cache the instance, to improve performance while building dependencies trees across the solution during solution load.The same optimisation is applied to
ImportTreeProvideras well.Microsoft Reviewers: Open in CodeFlow