Initialize feature flags in OOP early #12079
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwengier
force-pushed
the
CohostInitFeatureFlags
branch
from
4b6c2ca to
540d743
Compare
davidwengier
force-pushed
the
CohostInitFeatureFlags
branch
from
9ddcfb1 to
6de19ee
Compare
|
RPS isn't happy. Going to need to a new UIContext on the Roslyn side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possibly fixes, or maybe just makes less likely, #12069
Needs a Roslyn insertion before this will build, and will do a val build to make sure nothing regresses once that happens.
If the Speedometer/RPS complains, then the plan is to not fully initialize OOP early, but just initialize the MEF cache folder and cohost feature flag early, and leave the rest as is.