Refactor GetTaskListDescriptorsAsync to use async provider #12086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated OptionsStorage to use IAsyncServiceProvider for service retrieval. RPS Regression in Visual Studio where intellicode is not longer loading the ErrorList before Razor loads the errorlist This uses the Async service provider instead of the sync service provider
|
@davidwengier how to test this? There is a regression where the ErrorList is now loaded synchronously in VS. I think this changes would fix that. |
|
@pgroene you can do a test insertion by pushing your branch to https://dnceng.visualstudio.com/internal/_git/dotnet-razor and running https://dev.azure.com/dnceng/internal/_build?definitionId=262 against the branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated OptionsStorage to use IAsyncServiceProvider for service retrieval.
RPS Regression in Visual Studio where intellicode is not longer loading the ErrorList before Razor loads the errorlist
This uses the Async service provider instead of the sync service provider