Skip to content

*** WIP: Create PooledSpanBuilder, strongly based on PooledArrayBuilder #12095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

*** WIP: Create PooledSpanBuilder, strongly based on PooledArrayBuilder #12095

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
247a2ef
Implement PooledSpanBuilder directly from PooledArrayBuilder
ToddGrun Aug 9, 2025
928e139
Move to appropriate file
ToddGrun Aug 9, 2025
008da56
Restore PooledArrayBuilder classes
ToddGrun Aug 9, 2025
6942324
Add tests (thanks copilot!)
ToddGrun Aug 9, 2025
95e730f
Use PooledSpanBuilder in product code
ToddGrun Aug 9, 2025
605b4d9
Fix test failure from using a collection expression
ToddGrun Aug 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/Shared/Microsoft.AspNetCore.Razor.Utilities.Shared/PooledObjects/PooledArrayBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@

namespace Microsoft.AspNetCore.Razor.PooledObjects;

internal static class PooledArrayBuilder
internal static class PooledSpanBuilder
{
public static PooledArrayBuilder<T> Create<T>(ReadOnlySpan<T> source)
public static PooledSpanBuilder<T> Create<T>(ReadOnlySpan<T> source)
{
var pooledArray = new PooledArrayBuilder<T>(source.Length);
pooledArray.AddRange(source);
return pooledArray;
var spanBuilder = new PooledSpanBuilder<T>(source.Length);
spanBuilder.AddRange(source);
return spanBuilder;
}
}
Loading