Skip to content

Don't replace the slashes in hint names #12477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 19, 2025
Merged

Don't replace the slashes in hint names #12477

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
141a929
Don't replace the slashes in hintnames
chsienki Nov 11, 2025
ad1a289
Add test
chsienki Nov 11, 2025
e8f25f8
Normalize line endings + don't allow first char to be a slash
chsienki Nov 11, 2025
68e14f1
Fix generator tests
chsienki Nov 12, 2025
22d36ca
Apply suggestions from code review
chsienki Nov 12, 2025
6f2ba63
Apply suggestion from @chsienki
chsienki Nov 12, 2025
3f7dc68
Fix
chsienki Nov 18, 2025
489c30e
Merge branch 'main' into fix/hint_names
chsienki Nov 18, 2025
75ffe1e
Merge remote-tracking branch 'upstream/main' into fix/hint_names
chsienki Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...icrosoft.CodeAnalysis.Razor.Compiler/src/SourceGenerators/RazorSourceGenerator.Helpers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@ internal static string GetIdentifierFromPath(ReadOnlySpan<char> filePath)
{
switch (filePath[i])
{
case ':' or '\\' or '/':
Copy link
Member Author

@chsienki chsienki Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

':' is covered by the case below anyway.

case '\\' or '/' when i > 0:
builder.Append('/');
break;
case char ch when !char.IsLetterOrDigit(ch):
builder.Append('_');
break;
Expand Down
46 changes: 39 additions & 7 deletions ...Microsoft.VisualStudioCode.RazorExtension.Test/Endpoints/Shared/ComputedTargetPathTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ public class ComputedTargetPathTest(ITestOutputHelper testOutputHelper) : Cohost
{
// What the source generator would produce for TestProjectData.SomeProjectPath
private static readonly string s_hintNamePrefix = PlatformInformation.IsWindows
? "c__users_example_src_SomeProject"
: "_home_example_SomeProject";
? "c_/users/example/src/SomeProject"
: "/home/example/SomeProject";

[Theory]
[InlineData(true, false)]
Expand All @@ -45,7 +45,7 @@ public async Task SingleDocument(bool projectPath, bool generateConfigFile)

var generatedDocument = await document.Project.TryGetSourceGeneratedDocumentForRazorDocumentAsync(document, DisposalToken);
Assert.NotNull(generatedDocument);
Assert.Equal($"{s_hintNamePrefix}_File1_razor.g.cs", generatedDocument.HintName);
Assert.Equal($"{s_hintNamePrefix}/File1_razor.g.cs", generatedDocument.HintName);
}

[Theory]
Expand All @@ -70,11 +70,11 @@ public async Task TwoDocumentsWithTheSameBaseFileName(bool generateTargetPath)

var generatedDocument = await doc1.Project.TryGetSourceGeneratedDocumentForRazorDocumentAsync(doc1, DisposalToken);
Assert.NotNull(generatedDocument);
Assert.Equal($"Pages_Index_razor.g.cs", generatedDocument.HintName);
Assert.Equal($"Pages/Index_razor.g.cs", generatedDocument.HintName);

generatedDocument = await doc2.Project.TryGetSourceGeneratedDocumentForRazorDocumentAsync(doc2, DisposalToken);
Assert.NotNull(generatedDocument);
Assert.Equal($"Components_Index_razor.g.cs", generatedDocument.HintName);
Assert.Equal($"Components/Index_razor.g.cs", generatedDocument.HintName);
}

[Theory]
Expand Down Expand Up @@ -102,10 +102,42 @@ public async Task TwoDocumentsWithTheSameBaseFileName_FullPathHintName(bool proj

var generatedDocument = await doc1.Project.TryGetSourceGeneratedDocumentForRazorDocumentAsync(doc1, DisposalToken);
Assert.NotNull(generatedDocument);
Assert.Equal($"{s_hintNamePrefix}_Pages_Index_razor.g.cs", generatedDocument.HintName);
Assert.Equal($"{s_hintNamePrefix}/Pages/Index_razor.g.cs", generatedDocument.HintName);

generatedDocument = await doc2.Project.TryGetSourceGeneratedDocumentForRazorDocumentAsync(doc2, DisposalToken);
Assert.NotNull(generatedDocument);
Assert.Equal($"{s_hintNamePrefix}_Components_Index_razor.g.cs", generatedDocument.HintName);
Assert.Equal($"{s_hintNamePrefix}/Components/Index_razor.g.cs", generatedDocument.HintName);
}

[Theory]
[InlineData(true, false)]
[InlineData(true, true)]
[InlineData(false, false)]
public async Task TwoDocumentsWithTheSameBaseHintName(bool projectPath, bool generateConfigFile)
{
var builder = new RazorProjectBuilder
{
ProjectFilePath = projectPath ? TestProjectData.SomeProject.FilePath : null,
GenerateGlobalConfigFile = generateConfigFile,
GenerateAdditionalDocumentMetadata = false,
GenerateMSBuildProjectDirectory = false
};

var doc1Id = builder.AddAdditionalDocument(FilePath(@"Pages\Index.razor"), SourceText.From(""));
var doc2Id = builder.AddAdditionalDocument(FilePath(@"Pages_Index.razor"), SourceText.From(""));

var solution = LocalWorkspace.CurrentSolution;
solution = builder.Build(solution);

var doc1 = solution.GetAdditionalDocument(doc1Id).AssumeNotNull();
var doc2 = solution.GetAdditionalDocument(doc2Id).AssumeNotNull();

var generatedDocument = await doc1.Project.TryGetSourceGeneratedDocumentForRazorDocumentAsync(doc1, DisposalToken);
Assert.NotNull(generatedDocument);
Assert.Equal($"{s_hintNamePrefix}/Pages/Index_razor.g.cs", generatedDocument.HintName);

generatedDocument = await doc2.Project.TryGetSourceGeneratedDocumentForRazorDocumentAsync(doc2, DisposalToken);
Assert.NotNull(generatedDocument);
Assert.Equal($"{s_hintNamePrefix}/Pages_Index_razor.g.cs", generatedDocument.HintName);
}
}
Loading