Fix @section directive incorrectly allowed in .razor files #12478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modified SectionDirective.cs to only register for RazorFileKind.Legacy - Added tests to verify section directive works in .cshtml but not in .razor files Co-authored-by: chsienki <[email protected]>
Copilot
AI
changed the title
[WIP] Remove @section legality from .razor files
Fix @section directive incorrectly allowed in .razor files
Nov 11, 2025
Copilot finished work on behalf of
chsienki
November 11, 2025 23:53
chsienki
approved these changes
Nov 12, 2025
Member
|
@dotnet/razor-tooling for reviews please :) |
Member
davidwengier
left a comment
davidwengier
left a comment
There was a problem hiding this comment.
@copilot can you add a compiler integration test for a component with @section in it, so we can see the code-gen and ensure nothing regresses. Perhaps something like:
@{ var section = "Section"; }
@section One:
<div>
This is @section one.
</div>
Member
|
@chsienki you should also take this out of draft if you're happy with it |
Added SectionDirective_NotAllowed integration test to verify code generation when @section is used in .razor files. The test confirms that @section is no longer recognized as a directive and is instead treated as regular content, preventing compilation errors. Co-authored-by: davidwengier <[email protected]>
Contributor
Author
... Added the compiler integration test The test shows that Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot finished work on behalf of
davidwengier
November 12, 2025 05:37
davidwengier
approved these changes
Nov 12, 2025
jjonescz
reviewed
Nov 12, 2025
| // Act | ||
| var generated = CompileToCSharp(""" | ||
| @{ var section = "Section"; } | ||
| @section One { <p>Content</p> } |
Member
There was a problem hiding this comment.
Consider also verifying what happens if section variable is not defined; for completness
| // The section directive should NOT be recognized in component files. | ||
| // Verify that no RazorDirective node for 'section' exists in the syntax tree | ||
| var directiveNodes = syntaxTree.Root.DescendantNodes() | ||
| .OfType<Microsoft.AspNetCore.Razor.Language.Syntax.RazorDirectiveSyntax>(); |
Member
There was a problem hiding this comment.
Should we similarly verify that such node exists in the test above?
| Children(section, c => Html(" <p>Hello World</p> ", c)); | ||
| } | ||
|
|
||
| [Fact] |
Member
There was a problem hiding this comment.
Consider adding WorkItem attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes
The
@sectiondirective was incorrectly registered for both.cshtml(MVC/Razor Pages) and.razor(Blazor components) files. Per documentation,@sectionis only valid in MVC/Razor Pages. Using it in.razorfiles produces compilation errors.Changes:
SectionDirective.cs: RemovedRazorFileKind.Componentfrom directive registrationSectionDirectivePassTest.cs: Added tests verifying directive availability per file kindComponentCodeGenerationTestBase.cs: Added integration testSectionDirective_NotAllowedto verify code generation behavior and prevent regressionsBefore:
After:
Code Generation Verification:
The integration test confirms that when
@sectionis used in a.razorfile, it is no longer recognized as a directive and is instead treated as regular content, preventing compilation errors. Baseline files demonstrate the expected code generation output for both runtime and design-time scenarios.Fixes: #11273
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.