Fix AsyncRx GroupByUntil double OnCompletedAsync bug #2201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2200
When the upstream source for a
GroupByUntilcompletes, theGroupByUntilcompletes all current groups. However, it didn't remove those groups from the list of current groups as it did so, which meant that when those groups unsubscribed from their duration-defining observables, those duration-defining observables would in turn complete, which would then cause theGroupByUntilto try to complete these groups a second time (because the mainOnCompletedAsynchandling wasn't removing the groups from its list of current groups as it removed them).This now removes groups from the list of current groups before calling
OnCompletedAsync. (It already did this in the case where groups were removed because they expired. This change means it also does it in the case where they are being removed due to the whole operator shutting down.)