-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Fix WasPropertyBackingFieldAccessChecked assertion with query continuations #81793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
b713396
Initial plan
Copilot aa899b4
Add VisitQueryClause to suppress property checking in query clauses
Copilot 296c549
Fix: Only set WasPropertyBackingFieldAccessChecked flag if not alread…
Copilot 8f78c88
Fix root cause: pass receiverIsCheckedForRValue: true for optimized G…
Copilot ed8e096
Revert unnecessary change
333fred 24384da
Fix issue link
333fred ea83009
Add a test for the missing diagnostics, ensure that diagnostics for `…
333fred 767c483
Revert back to upstream/main
333fred a5d6200
Fix broken cref to MakeQueryInvocation after signature change
Copilot 4b7d188
Apply refactoring: CheckValue creates new node under DEBUG, MakeQuery…
Copilot 266f4a9
Simplify cloning
333fred 0a99f68
Remove unneeded brace add
333fred fb3c16c
Remove unused parameter
333fred 8ba5089
Fixes
333fred 7c60e9c
Move function to a separate file
333fred File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This receiver (
e) is checked on line 263. I've re-audited the rest of the call sites ofMakeQueryInvocationand didn't see any others that need to be updated.