Skip to content

Remove unnecessary indirection in VS #81894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
tmat wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −70
Draft

Remove unnecessary indirection in VS #81894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/EditorFeatures/Core/EditAndContinue/EditAndContinueLanguageService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,8 @@
namespace Microsoft.CodeAnalysis.EditAndContinue;

[Shared]
[Export(typeof(IManagedHotReloadLanguageService3))]
[Export(typeof(IEditAndContinueSolutionProvider))]
[Export(typeof(EditAndContinueLanguageService))]
[ExportMetadata("UIContext", EditAndContinueUIContext.EncCapableProjectExistsInWorkspaceUIContextString)]
[method: ImportingConstructor]
[method: Obsolete(MefConstruction.ImportingConstructorMessage, error: true)]
internal sealed class EditAndContinueLanguageService(
Expand Down
66 changes: 0 additions & 66 deletions src/EditorFeatures/Core/EditAndContinue/EditAndContinueLanguageServiceBridge.cs
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions src/VisualStudio/Core/Def/RoslynPackage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,12 +102,12 @@ private async Task ProfferServiceBrokerServicesAsync(CancellationToken cancellat

serviceBrokerContainer.Proffer(
WorkspaceProjectFactoryServiceDescriptor.ServiceDescriptor,
(_, _, _, _) => ValueTask.FromResult<object?>(new WorkspaceProjectFactoryService(this.ComponentModel.GetService<IWorkspaceProjectContextFactory>())));
(_, _, _, _) => ValueTask.FromResult<object?>(new WorkspaceProjectFactoryService(ComponentModel.GetService<IWorkspaceProjectContextFactory>())));

// Must be profferred before any C#/VB projects are loaded and the corresponding UI context activated.
serviceBrokerContainer.Proffer(
ManagedHotReloadLanguageServiceDescriptor.Descriptor,
(_, _, _, _) => ValueTask.FromResult<object?>(new ManagedEditAndContinueLanguageServiceBridge(this.ComponentModel.GetService<EditAndContinueLanguageService>())));
(_, _, _, _) => ValueTask.FromResult<object?>(ComponentModel.GetService<EditAndContinueLanguageService>()));
}

protected override async Task LoadComponentsAsync(CancellationToken cancellationToken)
Expand Down
Loading