Skip to content

Centralize LanguageServer exit codes per Jason's suggestion#82415

Open
Copilot wants to merge 2 commits intomainfrom
copilot/implement-exit-code-definitions
Open

Centralize LanguageServer exit codes per Jason's suggestion#82415
Copilot wants to merge 2 commits intomainfrom
copilot/implement-exit-code-definitions

Conversation

Copy link
Contributor

Copilot AI commented Feb 15, 2026

Implements suggestion from #82348 (review) to use Environment.Exit() with documented exit codes instead of Process.GetCurrentProcess().Kill().

Changes:

  • Added ServerExitCodes.cs defining exit code constants with XML documentation
  • Updated RoslynLanguageServer.WaitForClientProcessExitAsync() to use Environment.Exit(ServerExitCodes.ClientProcessExited)

Exit code 1 now indicates the server terminated because the monitored client process exited, making debugging easier.

Co-authored-by: JoeRobich <611219+JoeRobich@users.noreply.github.com>
Copilot AI changed the title [WIP] Add centralized exit code definitions for LanguageServer Centralize LanguageServer exit codes per Jason's suggestion Feb 15, 2026
Copilot AI requested a review from JoeRobich February 15, 2026 00:12
@JoeRobich JoeRobich marked this pull request as ready for review February 15, 2026 00:18
@JoeRobich JoeRobich requested a review from a team as a code owner February 15, 2026 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants