Add support for SHA-384 and SHA-512 hash algorithms#82452
Open
jcouv wants to merge 2 commits intodotnet:mainfrom
Open
Add support for SHA-384 and SHA-512 hash algorithms#82452jcouv wants to merge 2 commits intodotnet:mainfrom
jcouv wants to merge 2 commits intodotnet:mainfrom
Conversation
dotnet-policy-service
bot
added
the
Needs API Review
Contributor
|
This PR modifies public API files. Please follow the instructions at https://github.com/dotnet/roslyn/blob/main/docs/contributing/API%20Review%20Process.md for ensuring all public APIs are reviewed before merging. |
tmat
reviewed
Feb 19, 2026
| var compilation = CreateCompilation(new[] { tree1, tree256, tree384, tree512 }); | ||
|
|
||
| // The checksumAlgorithm values for SHA-384 and SHA-512 below use raw GUIDs instead of friendly | ||
| // names (like "SHA384"/"SHA512") because SRM's PdbToXmlConverter doesn't yet recognize these GUIDs. |
Member
There was a problem hiding this comment.
This will fix it: dotnet/symreader-converter#326. Let's wait for the new package, should be available shortly. #Closed
Member
There was a problem hiding this comment.
tmat
approved these changes
Feb 19, 2026
jjonescz
approved these changes
Feb 20, 2026
| @@ -1,4 +1,6 @@ | |||
| Microsoft.CodeAnalysis.Emit.EmitDifferenceOptions.MethodImplEntriesSupported.get -> bool | |||
| Microsoft.CodeAnalysis.Text.SourceHashAlgorithm.Sha384 = 3 -> Microsoft.CodeAnalysis.Text.SourceHashAlgorithm | |||
| Microsoft.CodeAnalysis.Text.SourceHashAlgorithm.Sha512 = 4 -> Microsoft.CodeAnalysis.Text.SourceHashAlgorithm | |||
Member
Author
There was a problem hiding this comment.
It will. Talked to Fred, we'll do it by email since trivial.
RikkiGibson
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corresponding spec update: dotnet/runtime#124573
Corresponding API proposal: #82478
Related updates in other repos, for future reference: