Support dotnet_diagnostic options for source generated files#82470
Draft
333fred wants to merge 8 commits intodotnet:mainfrom
Draft
Support dotnet_diagnostic options for source generated files#82470333fred wants to merge 8 commits intodotnet:mainfrom
dotnet_diagnostic options for source generated files#82470333fred wants to merge 8 commits intodotnet:mainfrom
Conversation
Contributor
|
This PR modifies public API files. Please follow the instructions at https://github.com/dotnet/roslyn/blob/main/docs/contributing/API%20Review%20Process.md for ensuring all public APIs are reviewed before merging. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #82285, fixes #41171.
Implements the API proposal from #82285. We now support the following section:
The
$generated$path is considered to be relative to the project root. This means that a**is necessary at the start of many$generated$paths, since many.editorconfigs live above a project root, not within the project root. Under the project root, the standard generator path is used. This is usually the name of the dll the generator came from, followed by the specific generator in question, followed by the hint name for the file the generator chose. For example, for a generator project/assembly namedMyCoolGenerator, a generator inside namedGeneratesCoolThings, and a hint name ofCoolThing.g.cs, the path from the consuming project root would be$generated$/MyCoolGenerator/MyCoolGenerator.GeneratesCoolThings/CoolThing.g.cs.