IDecompilationService - Use Assembly.GetName().Version rather than FileVersionInfo.GetVersionInfo#82490
Open
MattParkerDev wants to merge 1 commit intodotnet:mainfrom
Open
IDecompilationService - Use Assembly.GetName().Version rather than FileVersionInfo.GetVersionInfo#82490MattParkerDev wants to merge 1 commit intodotnet:mainfrom
MattParkerDev wants to merge 1 commit intodotnet:mainfrom
Conversation
dotnet-policy-service
bot
added
Community
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FileVersionInfo.GetVersionInfo requires a path to an assembly on disk. This fails in cases where the assembly has been loaded as a stream, rather than from a file.
This replaces it with Assembly.GetName().Version, which I have verified returns the same string, in this case, for ICSharpCode.Decompiler - "9.1.0.7988".
This will also improve performance (probably unnoticeably), as it doesn't need to read the assembly details from disk.