Reduce allocations under CodeFixService.GetShouldIncludeDiagnosticPredicate#82492
Draft
ToddGrun wants to merge 1 commit intodotnet:mainfrom
Draft
Reduce allocations under CodeFixService.GetShouldIncludeDiagnosticPredicate#82492ToddGrun wants to merge 1 commit intodotnet:mainfrom
ToddGrun wants to merge 1 commit intodotnet:mainfrom
Conversation
…dicate Populating both an ImmutableDictionary and an ImmutableHashSet both show up in the LightBulbInvocationTestForCSharp speedometer profile I'm looking at, accounting for about 5 MB (0.5%) of allocations. In draft mode until I get back speedometer results.
Contributor
Author
|
/pr-val |
Contributor
|
View PR Validation Run triggered by @ToddGrun Parameters
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In draft mode until I get back speedometer results.
Populating both an ImmutableDictionary and an ImmutableHashSet both show up in the LightBulbInvocationTestForCSharp speedometer profile I'm looking at, accounting for about 5 MB (0.5%) of allocations.