Skip to content

Reapply "Use rangecheck in assertprop (#112766)" (#112872) #112907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 26, 2025
Merged

Reapply "Use rangecheck in assertprop (#112766)" (#112872) #112907

merged 4 commits into from
Feb 26, 2025

Conversation

@EgorBo
Copy link
Member

@EgorBo EgorBo commented Feb 25, 2025 •
edited
Loading

This reverts commit db681fb.

Should be good now as the underlying issue was fixed in #112889

Diffs

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 25, 2025
@EgorBo
Copy link
Member Author

EgorBo commented Feb 25, 2025

/azp run runtime-coreclr libraries-pgo, runtime-coreclr jitstress, runtime-coreclr libraries-jitstress

@azure-pipelines
Copy link

azure-pipelines bot commented Feb 25, 2025

Azure Pipelines successfully started running 3 pipeline(s).

@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Feb 25, 2025

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

This was referenced Feb 25, 2025
Open
Open
@EgorBo EgorBo mentioned this pull request Feb 26, 2025
Open
@EgorBo EgorBo marked this pull request as ready for review February 26, 2025 18:05
Copilot AI review requested due to automatic review settings February 26, 2025 18:05
Copilot AI reviewed Feb 26, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

@EgorBo
Copy link
Member Author

EgorBo commented Feb 26, 2025

@jakobbotsch @AndyAyersMS PTAL, this revert of the revert has no new changes since the actual bug was in the assertions my code relied on (fixed via #112889)

No issues in runtime-coreclr libraries-pgo, runtime-coreclr jitstress, runtime-coreclr libraries-jitstress pipelines

@EgorBo
Copy link
Member Author

EgorBo commented Feb 26, 2025

/ba-g "osx-arm64 pipeline is stuck"

@EgorBo EgorBo merged commit f99e58b into dotnet:main Feb 26, 2025
109 of 112 checks passed
@EgorBo EgorBo deleted the use-rangecheck-assertprop-3 branch February 26, 2025 20:13
@amanasifkhalid amanasifkhalid mentioned this pull request Mar 17, 2025
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@jakobbotsch jakobbotsch jakobbotsch approved these changes

@AndyAyersMS AndyAyersMS AndyAyersMS approved these changes

Assignees

@EgorBo EgorBo

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@EgorBo @jakobbotsch @AndyAyersMS