-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Add bootstrapping build mechanism and enable for SourceBuild #114285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jkoritzinsky
merged 32 commits into
dotnet:main
from
jkoritzinsky:dotnetbuild-local-props-bootstrap
May 2, 2025
Merged
Changes from 24 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
2c52e80
Revert "Publish with BaseOS RID when its present"
jkoritzinsky 7c8bc6e
WIP: Bootstrap build instead of staged build
jkoritzinsky c5a67c0
Fix bootstrap restore.
jkoritzinsky 5fc4b0a
Get ILC and crossgen2 publishing with bootstrap subset + use-bootstrap
jkoritzinsky 3ae8a10
Remove two-stage build and convert to bootstrap build.
jkoritzinsky ae6824b
Don't build OOB libs in bootstrapping. They're not needed
jkoritzinsky 6c353f8
Layout bootstrap files in a separate directory so our actual product …
jkoritzinsky 4d69c06
Fix condition for bootstrap in SB
jkoritzinsky b22b99c
Various refactorings and put cdac on the same plan as ilc/crossgen2
jkoritzinsky 64667ef
Strip double-dash options too as they can be specified
jkoritzinsky c12698a
Update eng/build.sh
jkoritzinsky b631070
Update eng/DotNetBuild.props
jkoritzinsky efeda56
Apply suggestion
jkoritzinsky 0b066ed
Don't remove the source-built-upstream-cache folder
jkoritzinsky 59c078f
Fix loongarch64 leg
jkoritzinsky f23c641
Generate breadcrumbs in runtime.proj (where we build the aotsdk folder).
jkoritzinsky 9400e95
Adjust trimming tests to hook into targetingpacks.targets refactored …
jkoritzinsky 2d6e806
Add documentation
jkoritzinsky de101ab
Fix local apphost path hookup
jkoritzinsky 54630a9
Docs feedback
jkoritzinsky 4c611b1
Merge branch 'main' of github.com:dotnet/runtime into dotnetbuild-loc…
jkoritzinsky 9fb4c78
Build hosts in runtime-linker-tests now that we're using the live hosts.
jkoritzinsky bc6ec22
Use the targetingpacks.targets process for a live apphost
jkoritzinsky d798f2a
PR feedback
jkoritzinsky ef6a6f8
Add to build.sh
jkoritzinsky 053dcae
Fix up RID graph in the bootstrapping
jkoritzinsky d109c64
Merge branch 'main' of github.com:dotnet/runtime into dotnetbuild-loc…
jkoritzinsky e494fa9
Pass the right RID graph for NativeExports
jkoritzinsky feff1e1
Fix bootstrap for community portable platforms
jkoritzinsky 79115e3
Update eng/Subsets.props
jkoritzinsky cbc3b61
Update eng/Subsets.props
jkoritzinsky ab7e4e7
Merge branch 'main' into dotnetbuild-local-props-bootstrap
jkoritzinsky File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good for me. I wonder if
TargetRid!=NETCoreSdkRuntimeIdentifiermight be an alternative?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't use that by itself because that would cause this to trigger on some (but not all) Unified Build legs.
For Unified Build, we'll want this on either for 100% of the verticals or never.