Skip to content

Add dotnet to the path for copilot agent #115912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericstj merged 4 commits into from
May 23, 2025
Merged

Add dotnet to the path for copilot agent #115912

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
db21c8b
Add dotnet to the path for copilot agent
ericstj May 22, 2025
444e5ad
Update .github/workflows/copilot-setup-steps.yml
ericstj May 22, 2025
db7de8b
Add dependency install step
ericstj May 22, 2025
b0e6ba8
Sudo install dependencies + info
ericstj May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/copilot-setup-steps.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,11 @@ jobs:
steps:
- uses: actions/checkout@v4.2.2

- name: Install dependencies
run: sudo ./eng/common/native/install-dependencies.sh
Copy link
Member

@CarnaViire CarnaViire May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jfyi I'm not sure this script is enough; the helix docker images install a lot more https://github.com/dotnet/dotnet-buildtools-prereqs-docker/blob/main/src/ubuntu/25.04/helix/Dockerfile

Copy link
Member Author

@ericstj ericstj May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO if we are missing anything we need for local dev we should improve the script that we tell contributors to run rather than duplicate a bunch of custom logic with dubious origin that's accumulated over time. I see a lot of things in that dockerfile that look specific to helix.

If we need steps that a specific to local testing of runtime, let's create a common script that we put in eng and update the contribution docs to mention it. Those can create single runtime script that invokes the common arcade provided one.

I think we should do that as problems arise so that we keep a minimal accurate set of contribution pre-requisites that's documented.

Copy link
Member Author

@ericstj ericstj May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yet another place we describe these is here https://github.com/dotnet/runtime/tree/main/.devcontainer which I think drives the codespaces feature. @ellismg -- any idea if we can dedup these steps with copilot agent?

Copy link
Member Author

@ericstj ericstj May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tracking improvements as part of #115946 will merge this so we can continue experimenting.

- name: Restore solution
run: ./build.sh --restore --excludecibinarylog --warnaserror false /p:BuildAllConfigurations=true /p:DotNetBuildAllRuntimePacks=true
- name: Put dotnet on the path
run: echo "PATH=$PWD/.dotnet:$PATH" >> $GITHUB_ENV
- name: Run dotnet info
run: dotnet --info