Skip to content

arm64: Pass imm value directly to Sve function in SveVecImmUnOpTest Template #118518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

arm64: Pass imm value directly to Sve function in SveVecImmUnOpTest Template #118518

wants to merge 1 commit into from
+26 −28

Conversation

jonathandavies-arm
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 8, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Aug 8, 2025
@jonathandavies-arm
Copy link
Contributor Author

@dotnet/arm64-contrib @amanasifkhalid

a74nh
a74nh approved these changes Aug 8, 2025
View reviewed changes
Copy link
Contributor

@a74nh a74nh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously the value was passed in via a register, so we wouldn't have gotten proper immediate testing.

We should consider ways of expanding the immediate testing to cover more values. But not for this PR.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a74nh a74nh a74nh approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
community-contribution Indicates that the PR has been added by a community member needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathandavies-arm @a74nh