-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Add stubs for CompositeMLDsa APIs #118520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
PranavSenthilnathan
merged 3 commits into
dotnet:main
from
PranavSenthilnathan:cdsa-new-api
Aug 11, 2025
+522
−0
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
31 changes: 31 additions & 0 deletions
31
src/libraries/Common/src/System/Security/Cryptography/CompositeMLDsaCng.Windows.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
// Licensed to the .NET Foundation under one or more agreements. | ||
// The .NET Foundation licenses this file to you under the MIT license. | ||
|
||
namespace System.Security.Cryptography | ||
{ | ||
public sealed partial class CompositeMLDsaCng : CompositeMLDsa | ||
{ | ||
public partial CngKey GetKey() => | ||
throw new PlatformNotSupportedException(SR.Format(SR.Cryptography_AlgorithmNotSupported, nameof(CompositeMLDsa))); | ||
|
||
/// <inheritdoc/> | ||
protected override int SignDataCore(ReadOnlySpan<byte> data, ReadOnlySpan<byte> context, Span<byte> destination) => | ||
throw new PlatformNotSupportedException(SR.Format(SR.Cryptography_AlgorithmNotSupported, nameof(CompositeMLDsa))); | ||
|
||
/// <inheritdoc/> | ||
protected override bool TryExportCompositeMLDsaPrivateKeyCore(Span<byte> destination, out int bytesWritten) => | ||
throw new PlatformNotSupportedException(SR.Format(SR.Cryptography_AlgorithmNotSupported, nameof(CompositeMLDsa))); | ||
|
||
/// <inheritdoc/> | ||
protected override bool TryExportCompositeMLDsaPublicKeyCore(Span<byte> destination, out int bytesWritten) => | ||
throw new PlatformNotSupportedException(SR.Format(SR.Cryptography_AlgorithmNotSupported, nameof(CompositeMLDsa))); | ||
|
||
/// <inheritdoc/> | ||
protected override bool TryExportPkcs8PrivateKeyCore(Span<byte> destination, out int bytesWritten) => | ||
throw new PlatformNotSupportedException(SR.Format(SR.Cryptography_AlgorithmNotSupported, nameof(CompositeMLDsa))); | ||
|
||
/// <inheritdoc/> | ||
protected override bool VerifyDataCore(ReadOnlySpan<byte> data, ReadOnlySpan<byte> context, ReadOnlySpan<byte> signature) => | ||
throw new PlatformNotSupportedException(SR.Format(SR.Cryptography_AlgorithmNotSupported, nameof(CompositeMLDsa))); | ||
} | ||
} |
60 changes: 60 additions & 0 deletions
60
src/libraries/Common/src/System/Security/Cryptography/CompositeMLDsaCng.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
// Licensed to the .NET Foundation under one or more agreements. | ||
// The .NET Foundation licenses this file to you under the MIT license. | ||
|
||
using System.Diagnostics.CodeAnalysis; | ||
using System.Runtime.Versioning; | ||
|
||
namespace System.Security.Cryptography | ||
{ | ||
/// <summary> | ||
/// Provides a Cryptography Next Generation (CNG) implementation of Composite ML-DSA. | ||
/// </summary> | ||
/// <remarks> | ||
/// <para> | ||
/// Developers are encouraged to program against the <see cref="CompositeMLDsa" /> base class, | ||
/// rather than any specific derived class. | ||
/// The derived classes are intended for interop with the underlying system | ||
/// cryptographic libraries. | ||
/// </para> | ||
/// </remarks> | ||
[Experimental(Experimentals.PostQuantumCryptographyDiagId, UrlFormat = Experimentals.SharedUrlFormat)] | ||
public sealed partial class CompositeMLDsaCng : CompositeMLDsa | ||
{ | ||
/// <summary> | ||
/// Initializes a new instance of the <see cref="CompositeMLDsaCng"/> class by using the specified <see cref="CngKey"/>. | ||
/// </summary> | ||
/// <param name="key"> | ||
/// The key that will be used as input to the cryptographic operations performed by the current object. | ||
/// </param> | ||
/// <exception cref="ArgumentNullException"> | ||
/// <paramref name="key"/> is <see langword="null"/>. | ||
/// </exception> | ||
/// <exception cref="ArgumentException"> | ||
/// <paramref name="key"/> does not specify a Composite ML-DSA group. | ||
/// </exception> | ||
/// <exception cref="PlatformNotSupportedException"> | ||
/// Cryptography Next Generation (CNG) classes are not supported on this system. | ||
/// </exception> | ||
[SupportedOSPlatform("windows")] | ||
public CompositeMLDsaCng(CngKey key) | ||
: base(AlgorithmFromHandle(key)) | ||
{ | ||
throw new PlatformNotSupportedException(); | ||
} | ||
|
||
private static CompositeMLDsaAlgorithm AlgorithmFromHandle(CngKey key) => | ||
throw new PlatformNotSupportedException(); | ||
|
||
/// <summary> | ||
/// Gets a new <see cref="CngKey" /> representing the key used by the current instance. | ||
/// </summary> | ||
/// <exception cref="ObjectDisposedException"> | ||
/// This instance has been disposed. | ||
/// </exception> | ||
/// <remarks> | ||
/// This <see cref="CngKey"/> object is not the same as the one passed to <see cref="CompositeMLDsaCng(CngKey)"/>, | ||
/// if that constructor was used. However, it will point to the same CNG key. | ||
/// </remarks> | ||
public partial CngKey GetKey(); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.