Skip to content

JIT: Do not mark small types RegOptional as part of GT_LONG contained by HWIntrinsic #118550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

saucecontrol
Copy link
Member

@saucecontrol saucecontrol commented Aug 8, 2025

Fixes #118466

I was unable to get the repro from #118466 to fail when converted to an Xunit test, but this fixes the assert (and codegen) seen in the standalone repro.

Before (when bypassing the assert):

IN0015: 00004E xor      edx, edx
IN0016: 000050 vmovd    xmm0, dword ptr [V00 ebp-0x08]
IN0017: 000055 vpinsrd  xmm0, xmm0, edx, 1
IN0018: 00005B vpbroadcastq xmm0, xmm0

After:

IN0015: 00004E movzx    edx, byte  ptr [V00 ebp-0x08]
IN0016: 000052 xor      ecx, ecx
IN0017: 000054 vmovd    xmm0, edx
IN0018: 000058 vpinsrd  xmm0, xmm0, ecx, 1
IN0019: 00005E vpbroadcastq xmm0, xmm0

@github-actions github-actions bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Aug 8, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Aug 8, 2025
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@AndyAyersMS
Copy link
Member

@dotnet/jit-contrib FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JIT: Assertion failed 'isContainable || supportsRegOptional'
2 participants