Re-enable tests for Sys.RT.Caching #118551
Open
+51
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-area-label
There was a problem hiding this comment.
Pull Request Overview
This pull request re-enables and improves tests for the System.Runtime.Caching library by removing obsolete test annotations and enhancing test coverage. The changes focus on making tests run more broadly across platforms and improving their reliability through better isolation.
- Removes restrictive
[ActiveIssue],[PlatformSpecific], and[SkipOnPlatform]annotations that were preventing tests from running - Adds a new comprehensive test for file change monitoring with cache expiration
- Improves test isolation by making the
SetupMonitoringhelper accept unique identifiers
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
MemoryCacheTest.cs |
Removes outdated test annotations to enable broader test execution across platforms |
HostFileChangeMonitorTest.cs |
Removes test restrictions, improves test isolation with unique IDs, and adds new file change monitoring test |
src/libraries/System.Runtime.Caching/tests/System.Runtime.Caching/HostFileChangeMonitorTest.cs
Show resolved
Hide resolved
src/libraries/System.Runtime.Caching/tests/System.Runtime.Caching/HostFileChangeMonitorTest.cs
Show resolved
Hide resolved
|
For @mconnew, here's the comment you had on the outdated version of this PR: #118508 (review) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the
System.Runtime.Cachingtest suite to improve coverage and maintainability. The main changes include removing obsolete or restrictive test annotations, refactoring test helpers for better isolation, and adding a new test to verify cache item expiration behavior when file dependencies change.Test coverage and reliability improvements:
[OuterLoop]testReasonable_DelayinHostFileChangeMonitorTest.csto verify that cache items expire promptly when a monitored file changes.SetupMonitoringhelper to accept a unique ID, ensuring test file isolation and reducing interference between tests. [1] [2]Test annotation and platform restriction cleanup:
[ActiveIssue],[PlatformSpecific], and[SkipOnPlatform]annotations from several tests in bothHostFileChangeMonitorTest.csandMemoryCacheTest.cs, enabling broader test execution across platforms and configurations. [1] [2] [3] [4] [5] [6] [7]General code and import maintenance:
HostFileChangeMonitorTest.csto remove unnecessary imports and improve code clarity.