Add DataContractSerializer tests for System.Globalization types #118558
+14
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and System.Globalization.SortVersion Co-authored-by: StephenMolloy <[email protected]>
Copilot
AI
changed the title
Copilot finished work on behalf of
StephenMolloy
August 9, 2025 17:13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds missing test coverage for DataContractSerializer serialization of System.Globalization types as requested in the issue.
Changes Made
Added two new test methods to
DataContractSerializer.cs:DCS_CompareInfoAsRoot()- Tests serialization/deserialization ofSystem.Globalization.CompareInfousingCultureInfo.InvariantCulture.CompareInfoDCS_SortVersionAsRoot()- Tests serialization/deserialization ofSystem.Globalization.SortVersionusing the version from InvariantCulture's CompareInfoBoth tests follow the existing pattern using
DataContractSerializerHelper.SerializeAndDeserialize<T>()and verify that the objects can be successfully serialized to XML and deserialized back to equivalent objects.Testing
The implementation is minimal and surgical, adding only the required test coverage without modifying any existing functionality.
Fixes #24358.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.