[browser] Generate source maps as hidden in Release configuration #118635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the source map generation behavior for browser runtime builds to follow Blazor's pattern. In Release configuration, source maps are now generated as "hidden" (without the source map URL comment in the JavaScript files), while Debug builds continue to include visible source map links.
- Updates source map generation to be conditional based on build configuration
- Prevents confusion from browser warnings when source maps are missing in production
pavelsavara
approved these changes
Aug 12, 2025
pavelsavara
reviewed
Aug 12, 2025
How come? We still produce the source map, we just omit the comment in the JavaScript file. |
maraf
changed the title
javiercn
approved these changes
Aug 12, 2025
Fair, LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow the pattern from Blazor dotnet/aspnetcore#62558.
Although having the link in the JavaScript files don't cause any requests and so failures until the DevTools are opened, producing such errors/warnings into the console of user applications might cause confusion.
Fixes #98288