Skip to content

[RyuJIT Wasm] Cast Operations Follow Up #122862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamperlin merged 33 commits into from
Jan 24, 2026
Merged

[RyuJIT Wasm] Cast Operations Follow Up #122862

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
9288c02
Checkpoint
kg Dec 8, 2025
85f2b80
Add unary opcodes
kg Dec 8, 2025
7dbe5ff
Checkpoint
kg Dec 8, 2025
124c8dd
Checkpoint
kg Dec 8, 2025
eb34147
Checkpoint
kg Dec 8, 2025
e3d59bc
Checkpoint
kg Dec 8, 2025
71eb61b
Apply JIT format patch
kg Dec 8, 2025
3988828
Update src/coreclr/jit/codegenwasm.cpp
kg Dec 8, 2025
afadd5d
Merge branch 'main' of github.com:dotnet/runtime into kg/ryujit-wasm-…
adamperlin Dec 17, 2025
83410d9
Fix some initial review feedback in wasm codegen for casts
adamperlin Dec 18, 2025
ba132f4
Merge branch 'main' of github.com:dotnet/runtime into adamperlin/ryuj…
adamperlin Jan 6, 2026
f3e9e63
Re-use main genCodeForCast, genIntToIntCast implementation to handle …
adamperlin Jan 14, 2026
9b7f09b
Merge branch 'main' of github.com:dotnet/runtime into adamperlin/ryuj…
adamperlin Jan 14, 2026
386f93a
Remove helper calls for double->(u)long conversions on Wasm, jit-format
adamperlin Jan 14, 2026
c88d66b
Remove stray print
adamperlin Jan 14, 2026
0247f91
Add unreached() in some cases for casts
adamperlin Jan 14, 2026
d7f643b
Make cast op size estimates more precise to include 2 byte float -> i…
adamperlin Jan 14, 2026
11ec0a8
Add missing genConsumeRegs calls
adamperlin Jan 14, 2026
2031845
Revert cpp.hint file changes
adamperlin Jan 14, 2026
4e8ec4a
Fix missing small int -> long case
adamperlin Jan 14, 2026
a4ad71a
jit-format
adamperlin Jan 14, 2026
44c87f4
Address some initial review feedback
adamperlin Jan 15, 2026
cc76584
Additional review feedback
adamperlin Jan 15, 2026
1b1865f
Add details to comment for cast operation costing under Wasm
adamperlin Jan 15, 2026
ec11645
jit-format
adamperlin Jan 15, 2026
b62b9ba
Re-insert some ifdefs instead of moving code location in codegenlinea…
adamperlin Jan 15, 2026
beb5049
Address more review feedback
adamperlin Jan 15, 2026
cfb2ce1
Update src/coreclr/jit/codegenwasm.cpp
adamperlin Jan 19, 2026
cae1c5f
Address some additional review feedback
adamperlin Jan 23, 2026
b20e4d9
Merge branch 'main' of github.com:dotnet/runtime into adamperlin/ryuj…
adamperlin Jan 23, 2026
a0fce7d
Remove unnecessary ifdef for load containment in casts (we shouldn't …
adamperlin Jan 23, 2026
9b03be5
Merge branch 'adamperlin/ryujit-wasm-cast' of github.com:adamperlin/r…
adamperlin Jan 23, 2026
fcd500b
jit-format
adamperlin Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/coreclr/jit/codegen.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -814,7 +814,7 @@ class CodeGen final : public CodeGenInterface
CHECK_NONE,
CHECK_SMALL_INT_RANGE,
CHECK_POSITIVE,
#ifdef TARGET_64BIT
#if defined(TARGET_64BIT) || defined(TARGET_WASM)
CHECK_UINT_RANGE,
CHECK_POSITIVE_INT_RANGE,
CHECK_INT_RANGE,
Expand All @@ -826,13 +826,13 @@ class CodeGen final : public CodeGenInterface
COPY,
ZERO_EXTEND_SMALL_INT,
SIGN_EXTEND_SMALL_INT,
#ifdef TARGET_64BIT
#if defined(TARGET_64BIT) || defined(TARGET_WASM)
ZERO_EXTEND_INT,
SIGN_EXTEND_INT,
#endif
LOAD_ZERO_EXTEND_SMALL_INT,
LOAD_SIGN_EXTEND_SMALL_INT,
#ifdef TARGET_64BIT
#if defined(TARGET_64BIT) || defined(TARGET_WASM)
LOAD_ZERO_EXTEND_INT,
LOAD_SIGN_EXTEND_INT,
#endif
Expand Down
5 changes: 3 additions & 2 deletions src/coreclr/jit/codegeninterface.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,9 +169,10 @@ class CodeGenInterface
private:
#if defined(TARGET_XARCH)
static const insFlags instInfo[INS_count];
#elif defined(TARGET_ARM) || defined(TARGET_ARM64) || defined(TARGET_LOONGARCH64) || defined(TARGET_RISCV64) || \
defined(TARGET_WASM)
#elif defined(TARGET_ARM) || defined(TARGET_ARM64) || defined(TARGET_LOONGARCH64) || defined(TARGET_RISCV64)
static const BYTE instInfo[INS_count];
#elif defined(TARGET_WASM)
static const uint16_t instInfo[INS_count];
#else
#error Unsupported target architecture
#endif
Expand Down
Loading
Loading