Update cryptography tests for Windows 7 removal. #122877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some tests were conditioned to only run on Windows 7. Those tests were removed. Other tests were conditioned to run on things other that Windows 7. These conditions were removed.
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request removes Windows 7-specific test conditions from cryptography tests following the removal of Windows 7 support. The changes eliminate conditional test execution based on Windows 7 platform detection, allowing previously conditional tests to run unconditionally on all supported platforms.
Key Changes
- Removed entire test methods that were Windows 7-specific (tests that verified Windows 7 limitations)
- Converted conditional test attributes (
ConditionalFact/ConditionalTheory) to standard attributes (Fact/Theory) - Unwrapped test case data that was conditionally generated based on Windows 7 platform detection
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| X500DistinguishedNameTests.cs | Removed Windows 7 skip condition for TPM identifier test |
| RijndaelTests.cs | Removed Windows 7 CFB feedback size restriction check |
| DefaultDSAProvider.cs | Simplified FIPS 186-3 support check by removing Windows 7 condition |
| TripleDESContractTests.cs | Removed Windows 7-specific CFB64 unsupported test and converted conditional tests to unconditional |
| TripleDESCipherTests.cs | Converted 12 conditional CFB64 tests to unconditional facts/theories |
| SymmetricOneShotBase.cs | Converted 3 conditional CFB-related tests to unconditional |
| ImportExport.cs | Converted ImportZeroModulus test to unconditional theory |
| DESContractTests.cs | Removed Windows 7-specific CFB test and converted remaining CFB tests to unconditional |
| DESCipherTests.cs | Converted 12 conditional CFB8 cipher tests to unconditional theories/facts |
| DESCipherOneShotTests.cs | Unwrapped 10 CFB8 test cases that were conditionally generated for non-Windows 7 platforms |
| AesModeTests.cs | Removed Windows 7-specific CFB128 unsupported test and converted SupportsCFB128 to unconditional |
| AesContractTests.cs | Removed Windows 7 CFB feedback size restriction and fixed trailing whitespace |
| AesCipherTests.cs | Converted 18 conditional CFB128 cipher tests to unconditional and simplified test data generation |
| AesCipherOneShotTests.cs | Unwrapped 13 CFB128 test cases that were conditionally generated for non-Windows 7 platforms |
jkotas
approved these changes
Jan 5, 2026
Member
Author
|
These are test only changes to System.Security and all failures are known and not in System.Security. Merging. |
This was referenced Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests were conditioned to only run on Windows 7. Those tests were removed.
Other tests were conditioned to run on things other that Windows 7. These conditions were removed.
Best reviewed ignoring whitespace changes.