Skip to content

Fix trimming analyzer missing diagnostics for method calls in field access expressions #123040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 8 commits into
base: main
Choose a base branch
from

Fix test warnings: Use typeof(TestType) instead of o.GetType() to avo…

025264e
Select commit
Loading
Failed to load commit list.
Open

Fix trimming analyzer missing diagnostics for method calls in field access expressions #123040

Fix test warnings: Use typeof(TestType) instead of o.GetType() to avo…
025264e
Select commit
Loading
Failed to load commit list.
Azure Pipelines / dotnet-linker-tests failed Jan 15, 2026 in 1h 0m 27s

Build #20260115.51 had test failures

3 errors / 3 warnings

Details

Tests

  • Failed: 3 (0.04%)
  • Passed: 6,792 (98.14%)
  • Other: 126 (1.82%)
  • Total: 6,921

Annotations

Check failure on line 0 in XUnit

See this annotation in the file changed.

@azure-pipelines azure-pipelines / dotnet-linker-tests

XUnit#L0 

XUnit(0,0): error : (NETCORE_ENGINEERING_TELEMETRY=Test) Tests failed: /Users/runner/work/1/s/artifacts/TestResults/Release/ILLink.RoslynAnalyzer.Tests_net10.0_x64.html [net10.0|x64]

Check failure on line 0 in XUnit

See this annotation in the file changed.

@azure-pipelines azure-pipelines / dotnet-linker-tests

XUnit#L0 

XUnit(0,0): error : (NETCORE_ENGINEERING_TELEMETRY=Test) Tests failed: D:\a\_work\1\s\artifacts\TestResults\Release\ILLink.RoslynAnalyzer.Tests_net10.0_x64.html [net10.0|x64]

Check failure on line 0 in XUnit

See this annotation in the file changed.

@azure-pipelines azure-pipelines / dotnet-linker-tests

XUnit#L0 

XUnit(0,0): error : (NETCORE_ENGINEERING_TELEMETRY=Test) Tests failed: /__w/1/s/artifacts/TestResults/Release/ILLink.RoslynAnalyzer.Tests_net10.0_x64.html [net10.0|x64]

Check failure on line 1 in ILLink.RoslynAnalyzer.Tests.DataFlowTests.FieldDataFlow

See this annotation in the file changed.

@azure-pipelines azure-pipelines / dotnet-linker-tests

ILLink.RoslynAnalyzer.Tests.DataFlowTests.FieldDataFlow 

Unexpected warnings were generated:\n/__w/1/s/src/tools/illink/test/Mono.Linker.Tests.Cases/DataFlow/FieldDataFlow.cs(239,17): warning IL2072: 'unused' argument does not satisfy 'DynamicallyAccessedMemberTypes.All' in call to 'Mono.Linker.Tests.Cases.DataFlow.FieldDataFlow.AccessReturnedInstanceField.GetInstance(Type)'. The return value of method 'Mono.Linker.Tests.Cases.DataFlow.FieldDataFlow.GetUnknownType()' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to.\n/__w/1/s/src/tools/illink/test/Mono.Linker.Tests.Cases/DataFlow/FieldDataFlow.cs(253,17): warning IL2072: 'unused' argument does not satisfy 'DynamicallyAccessedMemberTypes.All' in call to 'Mono.Linker.Tests.Cases.DataFlow.FieldDataFlow.AccessReturnedInstanceField.GetInstance(Type)'. The return value of method 'Mono.Linker.Tests.Cases.DataFlow.FieldDataFlow.GetUnknownType()' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to.
Raw output 
   at ILLink.RoslynAnalyzer.Tests.TestChecker.Check(Boolean allowMissingWarnings) in /__w/1/s/src/tools/illink/test/ILLink.RoslynAnalyzer.Tests/TestChecker.cs:line 73
   at ILLink.RoslynAnalyzer.Tests.TestCaseUtils.RunTestFile(String suiteName, String testName, Boolean allowMissingWarnings, ValueTuple`2[] msbuildProperties) in /__w/1/s/src/tools/illink/test/ILLink.RoslynAnalyzer.Tests/TestCaseUtils.cs:line 86
--- End of stack trace from previous location ---

Check failure on line 1 in ILLink.RoslynAnalyzer.Tests.DataFlowTests.FieldDataFlow

See this annotation in the file changed.

@azure-pipelines azure-pipelines / dotnet-linker-tests

ILLink.RoslynAnalyzer.Tests.DataFlowTests.FieldDataFlow 

Unexpected warnings were generated:\r\nD:\\a\\_work\\1\\s\\src\\tools\\illink\\test\\Mono.Linker.Tests.Cases\\DataFlow\\FieldDataFlow.cs(239,17): warning IL2072: 'unused' argument does not satisfy 'DynamicallyAccessedMemberTypes.All' in call to 'Mono.Linker.Tests.Cases.DataFlow.FieldDataFlow.AccessReturnedInstanceField.GetInstance(Type)'. The return value of method 'Mono.Linker.Tests.Cases.DataFlow.FieldDataFlow.GetUnknownType()' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to.\r\nD:\\a\\_work\\1\\s\\src\\tools\\illink\\test\\Mono.Linker.Tests.Cases\\DataFlow\\FieldDataFlow.cs(253,17): warning IL2072: 'unused' argument does not satisfy 'DynamicallyAccessedMemberTypes.All' in call to 'Mono.Linker.Tests.Cases.DataFlow.FieldDataFlow.AccessReturnedInstanceField.GetInstance(Type)'. The return value of method 'Mono.Linker.Tests.Cases.DataFlow.FieldDataFlow.GetUnknownType()' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to.
Raw output 
   at ILLink.RoslynAnalyzer.Tests.TestChecker.Check(Boolean allowMissingWarnings) in D:\a\_work\1\s\src\tools\illink\test\ILLink.RoslynAnalyzer.Tests\TestChecker.cs:line 73
   at ILLink.RoslynAnalyzer.Tests.TestCaseUtils.RunTestFile(String suiteName, String testName, Boolean allowMissingWarnings, ValueTuple`2[] msbuildProperties) in D:\a\_work\1\s\src\tools\illink\test\ILLink.RoslynAnalyzer.Tests\TestCaseUtils.cs:line 86
--- End of stack trace from previous location ---

Check failure on line 1 in ILLink.RoslynAnalyzer.Tests.DataFlowTests.FieldDataFlow

See this annotation in the file changed.

@azure-pipelines azure-pipelines / dotnet-linker-tests

ILLink.RoslynAnalyzer.Tests.DataFlowTests.FieldDataFlow 

Unexpected warnings were generated:\n/Users/runner/work/1/s/src/tools/illink/test/Mono.Linker.Tests.Cases/DataFlow/FieldDataFlow.cs(239,17): warning IL2072: 'unused' argument does not satisfy 'DynamicallyAccessedMemberTypes.All' in call to 'Mono.Linker.Tests.Cases.DataFlow.FieldDataFlow.AccessReturnedInstanceField.GetInstance(Type)'. The return value of method 'Mono.Linker.Tests.Cases.DataFlow.FieldDataFlow.GetUnknownType()' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to.\n/Users/runner/work/1/s/src/tools/illink/test/Mono.Linker.Tests.Cases/DataFlow/FieldDataFlow.cs(253,17): warning IL2072: 'unused' argument does not satisfy 'DynamicallyAccessedMemberTypes.All' in call to 'Mono.Linker.Tests.Cases.DataFlow.FieldDataFlow.AccessReturnedInstanceField.GetInstance(Type)'. The return value of method 'Mono.Linker.Tests.Cases.DataFlow.FieldDataFlow.GetUnknownType()' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to.
Raw output 
   at ILLink.RoslynAnalyzer.Tests.TestChecker.Check(Boolean allowMissingWarnings) in /Users/runner/work/1/s/src/tools/illink/test/ILLink.RoslynAnalyzer.Tests/TestChecker.cs:line 73
   at ILLink.RoslynAnalyzer.Tests.TestCaseUtils.RunTestFile(String suiteName, String testName, Boolean allowMissingWarnings, ValueTuple`2[] msbuildProperties) in /Users/runner/work/1/s/src/tools/illink/test/ILLink.RoslynAnalyzer.Tests/TestCaseUtils.cs:line 86
--- End of stack trace from previous location ---
View more details on Azure Pipelines