Skip to content

fix ntlm tests on platforms with broken gssapi #123055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rzikm merged 4 commits into from
Jan 13, 2026
+12 −2
Merged

fix ntlm tests on platforms with broken gssapi #123055

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fa64c02
fix ntlm tests on platforms with broken gssapi
wfurt Jan 9, 2026
d54c88b
ubuntu26
wfurt Jan 12, 2026
9e940b2
Merge branch 'main' into ntlm
wfurt Jan 13, 2026
9d9bb50
Merge branch 'main' into ntlm
wfurt Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Unix.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ public static partial class PlatformDetection
public static bool IsLinux => RuntimeInformation.IsOSPlatform(OSPlatform.Linux);
public static bool IsOpenSUSE => IsDistroAndVersion("opensuse");
public static bool IsUbuntu => IsDistroAndVersion("ubuntu");
public static bool IsUbuntu26 => IsDistroAndVersion("ubuntu", 26);
public static bool IsUbuntu24 => IsDistroAndVersion("ubuntu", 24);
public static bool IsUbuntu24OrHigher => IsDistroAndVersionOrHigher("ubuntu", 24);
public static bool IsDebian => IsDistroAndVersion("debian");
Expand Down
13 changes: 11 additions & 2 deletions src/libraries/System.Net.Security/tests/UnitTests/NegotiateAuthenticationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,23 @@ namespace System.Net.Security.Tests
{
public class NegotiateAuthenticationTests
{
private static bool IsNtlmAvailable => Capability.IsNtlmInstalled() || OperatingSystem.IsAndroid() || OperatingSystem.IsTvOS();
// Ubuntu 24 and 26 ship with broekn gss-ntlmssp 1.2
private static bool UseManagedNtlm => PlatformDetection.IsUbuntu24 || PlatformDetection.IsUbuntu26;
private static bool IsNtlmAvailable => UseManagedNtlm || Capability.IsNtlmInstalled() || OperatingSystem.IsAndroid() || OperatingSystem.IsTvOS();
private static bool IsNtlmUnavailable => !IsNtlmAvailable;

private static NetworkCredential s_testCredentialRight = new NetworkCredential("rightusername", "rightpassword");
private static NetworkCredential s_testCredentialWrong = new NetworkCredential("rightusername", "wrongpassword");
private static readonly byte[] s_Hello = "Hello"u8.ToArray();

static NegotiateAuthenticationTests()
{
if (UseManagedNtlm)
{
AppContext.SetSwitch("System.Net.Security.UseManagedNtlm", true);
}
}

[Fact]
public void Constructor_Overloads_Validation()
{
Expand Down Expand Up @@ -85,7 +95,6 @@ public void Package_Supported_NTLM()
}

[ConditionalFact(nameof(IsNtlmUnavailable))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/111639", typeof(PlatformDetection), nameof(PlatformDetection.IsUbuntu24OrHigher))]
public void Package_Unsupported_NTLM()
{
NegotiateAuthenticationClientOptions clientOptions = new NegotiateAuthenticationClientOptions { Package = "NTLM", Credential = s_testCredentialRight, TargetName = "HTTP/foo" };
Expand Down
Loading