Skip to content

[release/10.0] Update MicrosoftCodeAnalysisVersion_LatestVS #123509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sbomer wants to merge 6 commits into from
+7 −1
Closed

[release/10.0] Update MicrosoftCodeAnalysisVersion_LatestVS #123509

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c13dcce
Update MicrosoftCodeAnalysisVersion_LatestVS
sbomer Jan 22, 2026
6ab6ed5
Remove redundant ToString() in string interpolation
sbomer Jan 22, 2026
8a9a637
Fix ReadOnlySpan interpolation for netstandard targets
sbomer Jan 22, 2026
2f81088
Use 10.0.100 SDK version
sbomer Jan 23, 2026
62d509c
Use 10.0.102 SDK version
sbomer Jan 23, 2026
696c98c
Use 5.0.0
sbomer Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/Versions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
Source-build builds the product with the most recent previously source-built release. Thankfully, these two requirements line up nicely
such that any version that satisfies the VS version requirement will also satisfy the .NET SDK version requirement because of how we ship.
-->
<MicrosoftCodeAnalysisVersion_LatestVS>4.14.0</MicrosoftCodeAnalysisVersion_LatestVS>
<MicrosoftCodeAnalysisVersion_LatestVS>5.0.0-2.26070.104</MicrosoftCodeAnalysisVersion_LatestVS>
Copy link
Member

@jkoritzinsky jkoritzinsky Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When porting this to main, can we introduce a new property like the ones above for the 10.0.1xx sdks?

Copy link
Member Author

@sbomer sbomer Jan 23, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see 10.0.100 SDK shipped with version 5.0.0-2.25523.111, maybe we should use that one instead @jkoritzinsky?
edit: seems that version isn't available in the nuget feeds. Could you help me pick the right version here?

Copy link
Member Author

@sbomer sbomer Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated this to use the version that ships with the 10.0.102 SDK as that was the earliest SDK-included version available in our nuget feeds (I tried 10.0.100 and 10.0.101 and those packages don't seem to exist, maybe they are removed from internal feeds once we ship?), and that version is lower than what's in the dotnet/sdk 10.0.1xxx branch so it seems slightly safer.

Copy link
Member

@jkoritzinsky jkoritzinsky Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another good option here would be to use 5.0.0 as the "Latest VS" version, as that is a publicly available version and definitely works in VS/.NET 10 SDK and has any expected API changes.

<!-- Some of the analyzer dependencies used by ILLink project -->
<MicrosoftCodeAnalysisBannedApiAnalyzersVersion>3.3.5-beta1.23270.2</MicrosoftCodeAnalysisBannedApiAnalyzersVersion>
</PropertyGroup>
Expand Down
2 changes: 2 additions & 0 deletions src/libraries/Common/src/System/Security/Cryptography/MLDsaCng.Windows.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,10 +449,12 @@ private void ExportKey(
keyBytes.Length != expectedKeySize ||
!parameterSet.SequenceEqual(expectedParameterSet))
{
#pragma warning disable IDE0071
Debug.Fail(
$"{nameof(blobType)}: {blobType}, " +
$"{nameof(parameterSet)}: {parameterSet.ToString()}, " +
$"{nameof(keyBytes)}.Length: {keyBytes.Length} / {expectedKeySize}");
#pragma warning restore IDE0071

throw new CryptographicException();
}
Expand Down
2 changes: 2 additions & 0 deletions src/libraries/Common/src/System/Security/Cryptography/MLDsaImplementation.Windows.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,10 +236,12 @@ private void ExportKey(string keyBlobType, int expectedKeySize, Span<byte> desti
keyBytes.Length != expectedKeySize ||
!parameterSet.SequenceEqual(expectedParameterSet))
{
#pragma warning disable IDE0071
Debug.Fail(
$"{nameof(blobType)}: {blobType}, " +
$"{nameof(parameterSet)}: {parameterSet.ToString()}, " +
$"{nameof(keyBytes)}.Length: {keyBytes.Length} / {expectedKeySize}");
#pragma warning restore IDE0071

throw new CryptographicException();
}
Expand Down
2 changes: 2 additions & 0 deletions src/libraries/System.Reflection.Metadata/src/System/Reflection/Metadata/TypeNameParser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,9 @@ private TypeNameParser(ReadOnlySpan<char> name, bool throwOnError, TypeNameParse
return null;
}

#pragma warning disable IDE0071
Debug.Assert(parsedName.GetNodeCount() == recursiveDepth, $"Node count mismatch for '{typeName.ToString()}'");
#pragma warning restore IDE0071

return parsedName;
}
Expand Down
Loading