Skip to content

Update MicrosoftCodeAnalysisVersion_LatestVS #123514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sbomer wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Update MicrosoftCodeAnalysisVersion_LatestVS #123514

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
22e155a
Update MicrosoftCodeAnalysisVersion_LatestVS
sbomer Jan 22, 2026
419a63e
Add 5_0 property
sbomer Jan 22, 2026
8d86ab0
Remove redundant ToString() in string interpolation
sbomer Jan 22, 2026
1bce9e7
Fix IDE0031 analyzer errors across libraries
sbomer Jan 23, 2026
22033b2
Merge branch 'main' into fixLatestVSMain
agocke Jan 23, 2026
d16a89f
Fix analyzer warning
agocke Jan 23, 2026
c495a4d
Fix IDE0031 and IDE0071 analyzer errors
sbomer Jan 23, 2026
c363866
Fix IDE0031 analyzer error
sbomer Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion eng/Versions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,8 @@
<MicrosoftCodeAnalysisVersion_4_4>4.4.0</MicrosoftCodeAnalysisVersion_4_4>
<!-- Compatibility with VS 17.8/.NET SDK 8.0.1xx -->
<MicrosoftCodeAnalysisVersion_4_8>4.8.0</MicrosoftCodeAnalysisVersion_4_8>
<!-- Compatibility with VS 18.0/.NET SDK 10.0.1xx -->
<MicrosoftCodeAnalysisVersion_5_0>5.0.0-2.26070.104</MicrosoftCodeAnalysisVersion_5_0>
<!-- Compatibility with the latest Visual Studio Preview release -->
<!--
The exact version is always a moving target. This version should never go ahead of the version of Roslyn that is included in the most recent
Expand All @@ -74,7 +76,7 @@
Source-build builds the product with the most recent previously source-built release. Thankfully, these two requirements line up nicely
such that any version that satisfies the VS version requirement will also satisfy the .NET SDK version requirement because of how we ship.
-->
<MicrosoftCodeAnalysisVersion_LatestVS>4.14.0</MicrosoftCodeAnalysisVersion_LatestVS>
<MicrosoftCodeAnalysisVersion_LatestVS>5.4.0-2.26060.102</MicrosoftCodeAnalysisVersion_LatestVS>
<!-- Some of the analyzer dependencies used by ILLink project -->
<MicrosoftCodeAnalysisBannedApiAnalyzersVersion>3.3.5-beta1.23270.2</MicrosoftCodeAnalysisBannedApiAnalyzersVersion>
</PropertyGroup>
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/Common/src/System/Security/Cryptography/MLDsaCng.Windows.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,7 +451,7 @@ private void ExportKey(
{
Debug.Fail(
$"{nameof(blobType)}: {blobType}, " +
$"{nameof(parameterSet)}: {parameterSet.ToString()}, " +
$"{nameof(parameterSet)}: {parameterSet}, " +
$"{nameof(keyBytes)}.Length: {keyBytes.Length} / {expectedKeySize}");

throw new CryptographicException();
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/Common/src/System/Security/Cryptography/MLDsaImplementation.Windows.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@
{
Debug.Fail(
$"{nameof(blobType)}: {blobType}, " +
$"{nameof(parameterSet)}: {parameterSet.ToString()}, " +
$"{nameof(parameterSet)}: {parameterSet}, " +

Check failure on line 241 in src/libraries/Common/src/System/Security/Cryptography/MLDsaImplementation.Windows.cs

View check run for this annotation

Azure Pipelines / runtime-dev-innerloop (Build Source-Build (Linux_x64))

src/libraries/Common/src/System/Security/Cryptography/MLDsaImplementation.Windows.cs#L241 

src/libraries/Common/src/System/Security/Cryptography/MLDsaImplementation.Windows.cs(241,52): error CS0029: (NETCORE_ENGINEERING_TELEMETRY=Build) Cannot implicitly convert type 'System.ReadOnlySpan<char>' to 'object'

Check failure on line 241 in src/libraries/Common/src/System/Security/Cryptography/MLDsaImplementation.Windows.cs

View check run for this annotation

Azure Pipelines / runtime-dev-innerloop (Build Source-Build (Linux_x64))

src/libraries/Common/src/System/Security/Cryptography/MLDsaImplementation.Windows.cs#L241 

src/libraries/Common/src/System/Security/Cryptography/MLDsaImplementation.Windows.cs(241,52): error CS0029: (NETCORE_ENGINEERING_TELEMETRY=Build) Cannot implicitly convert type 'System.ReadOnlySpan<char>' to 'object'
$"{nameof(keyBytes)}.Length: {keyBytes.Length} / {expectedKeySize}");

throw new CryptographicException();
Expand Down
2 changes: 2 additions & 0 deletions src/libraries/System.Reflection.Metadata/src/System/Reflection/Metadata/TypeNameParser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,9 @@ private TypeNameParser(ReadOnlySpan<char> name, bool throwOnError, TypeNameParse
return null;
}

#pragma warning disable IDE0071
Debug.Assert(parsedName.GetNodeCount() == recursiveDepth, $"Node count mismatch for '{typeName.ToString()}'");
#pragma warning restore IDE0071

return parsedName;
}
Expand Down
Loading