Skip to content

Fix nullable annotation on GetIPv4Properties #34257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2020
Merged

Fix nullable annotation on GetIPv4Properties #34257

merged 1 commit into from
Mar 30, 2020

Conversation

stephentoub
Copy link
Member

@stephentoub stephentoub commented Mar 29, 2020 •
edited
Loading

Fixes #33401
dotnet/dotnet-api-docs#4048 updates the docs.
cc: @buyaa-n, @eerhardt

@stephentoub stephentoub added this to the 5.0 milestone Mar 29, 2020
eerhardt
eerhardt approved these changes Mar 29, 2020
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stephentoub stephentoub merged commit 8772dd3 into dotnet:master Mar 30, 2020
@stephentoub stephentoub deleted the nullableipv4prop branch March 30, 2020 00:28
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eerhardt eerhardt eerhardt approved these changes

Assignees
No one assigned
Labels
area-System.Net
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

Nullability inconsistency between GetIPv4Properties() and GetIPv6Properties()
3 participants
@stephentoub @eerhardt @Dotnet-GitSync-Bot