Use prototype roslyn compiler#3062
Closed
agocke wants to merge 3 commits intodotnet:feature/async2-experimentfrom
Closed
Use prototype roslyn compiler#3062agocke wants to merge 3 commits intodotnet:feature/async2-experimentfrom
agocke wants to merge 3 commits intodotnet:feature/async2-experimentfrom
Conversation
Member
Author
|
Note: this currently fails due to the compiler throwing |
VSadov
reviewed
Apr 3, 2025
| <ItemGroup> | ||
| <Compile Include="$(MSBuildThisFileDirectory)RuntimeAsyncMethodGenerationAttribute.cs" /> | ||
| </ItemGroup> | ||
| </Project> No newline at end of file |
Member
There was a problem hiding this comment.
I think switching all tests to experimental compiler is good for runtimelab, but in main repo we might need to limit this to async folder.
I assume this will work in CI, right?
Member
|
I looked through the changes and PR looks reasonable. I think that can be handled by making an async1 wrapper over |
agocke
force-pushed
the
use-prototype-compiler
branch
2 times, most recently
from
dfeb272 to
c32bea3
Compare
agocke
force-pushed
the
use-prototype-compiler
branch
from
c32bea3 to
5ed0cee
Compare
Member
Author
|
Closing in favor of the runtime PR: dotnet/runtime#115531 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Everything under
asyncwill use the prototype compiler. All async methods will be compiled as async by default (the feature flag is enabled). The attribute definition for the tests is included, which can be used to selectively disable async2.