updating System.String samples for Try .NET #1200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mairaw, @BillWagner -- please hold off on reviewing this PR until I resolve the conflicts. #hold-off |
|
@mairaw -- Maira, feel free to review the non-conflicting samples. Thank you. |
|
Are you going to fix the merge conflicts? |
BillWagner
previously approved these changes
Aug 23, 2019
|
@mairaw, @BillWagner -- please conclude your review; my apologies for the earlier merge conflicts. |
BillWagner
reviewed
Aug 23, 2019
There was a problem hiding this comment.
I had one question @WilliamAntonRohm
Once we resolve that discussion, this is ready to 
|
#sign-off |
BillWagner
approved these changes
Aug 23, 2019
There was a problem hiding this comment.
Thanks for all the work here @WilliamAntonRohm We appreciate it.
After review and discussion, I'll now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per dotnet/dotnet-api-docs#2971