Skip to content

String.xml samples -- updating per Try .NET review comments #1916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 17, 2020
Merged

String.xml samples -- updating per Try .NET review comments #1916

merged 2 commits into from
Jan 17, 2020

Conversation

WilliamAntonRohm
Copy link
Contributor

@WilliamAntonRohm WilliamAntonRohm mentioned this pull request Jan 17, 2020
Merged
mairaw
mairaw approved these changes Jan 17, 2020
View reviewed changes
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @WilliamAntonRohm! I undid one of the changes, otherwise we had to change the VB version and the output here as well.

@mairaw mairaw merged commit 34f5a6f into dotnet:master Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mairaw mairaw mairaw approved these changes

@BillWagner BillWagner Awaiting requested review from BillWagner

Assignees

@WilliamAntonRohm WilliamAntonRohm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WilliamAntonRohm @mairaw