Respond to PR feedback

marcpopMSFT · web-flow · commit 539fc44db68a · 2025-05-13T16:10:50.000-07:00
diff --git a/test/Microsoft.NET.Build.Tests/GivenThatWeWantToVerifyNuGetReferenceCompat.cs b/test/Microsoft.NET.Build.Tests/GivenThatWeWantToVerifyNuGetReferenceCompat.cs
@@ -11,7 +11,6 @@ public GivenThatWeWantToVerifyNuGetReferenceCompat(ITestOutputHelper log) : base
         {
         }
 
-        // Reduced set of test cases that still verify the compatibility matrix
         [Theory]
         [InlineData("net45", "Full", "netstandard1.0 netstandard1.1 net45", true, true)]
         [InlineData("net462", "Full", "netstandard1.0 netstandard1.1 netstandard1.2 netstandard1.3 netstandard1.4 netstandard1.5 netstandard1.6 netstandard2.0 net45 net451 net46 net461 net462", true, true)]
@@ -59,7 +58,7 @@ public void Nuget_reference_compat(string referencerTarget, string testDescripti
                     if (!dependencyPackageReference.NuGetPackageExists() &&
                         (RuntimeInformation.IsOSPlatform(OSPlatform.Windows) || dependencyProject.BuildsOnNonWindows))
                     {
-                        if (!dependencyPackageReference.NuGetPackageExists()) // Double-check after lock
+                        if (!dependencyPackageReference.NuGetPackageExists())
                         {
                             var dependencyTestAsset = _testAssetsManager.CreateTestProject(
                                 dependencyProject,

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,6 @@ public GivenThatWeWantToVerifyNuGetReferenceCompat(ITestOutputHelper log) : base`
`11`	`11`	`{`
`12`	`12`	`}`
`13`	`13`
`14`		`- // Reduced set of test cases that still verify the compatibility matrix`
`15`	`14`	`[Theory]`
`16`	`15`	`[InlineData("net45", "Full", "netstandard1.0 netstandard1.1 net45", true, true)]`
`17`	`16`	`[InlineData("net462", "Full", "netstandard1.0 netstandard1.1 netstandard1.2 netstandard1.3 netstandard1.4 netstandard1.5 netstandard1.6 netstandard2.0 net45 net451 net46 net461 net462", true, true)]`
`@@ -59,7 +58,7 @@ public void Nuget_reference_compat(string referencerTarget, string testDescripti`
`59`	`58`	`if (!dependencyPackageReference.NuGetPackageExists() &&`
`60`	`59`	`(RuntimeInformation.IsOSPlatform(OSPlatform.Windows) \|\| dependencyProject.BuildsOnNonWindows))`
`61`	`60`	`{`
`62`		`- if (!dependencyPackageReference.NuGetPackageExists()) // Double-check after lock`
	`61`	`+ if (!dependencyPackageReference.NuGetPackageExists())`
`63`	`62`	`{`
`64`	`63`	`var dependencyTestAsset = _testAssetsManager.CreateTestProject(`
`65`	`64`	`dependencyProject,`