Print informational message for usage of launchSettings.json in dotnet test (#50112)

Author: Youssef1313

src/Cli/dotnet/Commands/Test/MSBuildUtility.cs

@@ -53,7 +53,7 @@ public static (IEnumerable<ParallelizableTestModuleGroupWithSequentialInnerModul
         FacadeLogger? logger = LoggerUtility.DetermineBinlogger([.. buildOptions.MSBuildArgs], dotnetTestVerb);
         var collection = new ProjectCollection(globalProperties: CommonRunHelpers.GetGlobalPropertiesFromArgs([.. buildOptions.MSBuildArgs]), logger is null ? null : [logger], toolsetDefinitionLocations: ToolsetDefinitionLocations.Default);
 
-        IEnumerable<ParallelizableTestModuleGroupWithSequentialInnerModules> projects = SolutionAndProjectUtility.GetProjectProperties(projectFilePath, collection, buildOptions.NoLaunchProfile);
+        IEnumerable<ParallelizableTestModuleGroupWithSequentialInnerModules> projects = SolutionAndProjectUtility.GetProjectProperties(projectFilePath, collection, buildOptions);
         logger?.ReallyShutdown();
 
         return (projects, isBuiltOrRestored);
@@ -119,7 +119,7 @@ private static ConcurrentBag<ParallelizableTestModuleGroupWithSequentialInnerMod
             new ParallelOptions { MaxDegreeOfParallelism = buildOptions.DegreeOfParallelism },
             (project) =>
             {
-                IEnumerable<ParallelizableTestModuleGroupWithSequentialInnerModules> projectsMetadata = SolutionAndProjectUtility.GetProjectProperties(project, projectCollection, buildOptions.NoLaunchProfile);
+                IEnumerable<ParallelizableTestModuleGroupWithSequentialInnerModules> projectsMetadata = SolutionAndProjectUtility.GetProjectProperties(project, projectCollection, buildOptions);
                 foreach (var projectMetadata in projectsMetadata)
                 {
                     allProjects.Add(projectMetadata);

src/Cli/dotnet/Commands/Test/SolutionAndProjectUtility.cs

@@ -147,7 +147,7 @@ public static string GetRootDirectory(string solutionOrProjectFilePath)
         return string.IsNullOrEmpty(fileDirectory) ? Directory.GetCurrentDirectory() : fileDirectory;
     }
 
-    public static IEnumerable<ParallelizableTestModuleGroupWithSequentialInnerModules> GetProjectProperties(string projectFilePath, ProjectCollection projectCollection, bool noLaunchProfile)
+    public static IEnumerable<ParallelizableTestModuleGroupWithSequentialInnerModules> GetProjectProperties(string projectFilePath, ProjectCollection projectCollection, BuildOptions buildOptions)
     {
         var projects = new List<ParallelizableTestModuleGroupWithSequentialInnerModules>();
         ProjectInstance projectInstance = EvaluateProject(projectCollection, projectFilePath, null);
@@ -159,7 +159,7 @@ public static IEnumerable<ParallelizableTestModuleGroupWithSequentialInnerModule
 
         if (!string.IsNullOrEmpty(targetFramework) || string.IsNullOrEmpty(targetFrameworks))
         {
-            if (GetModuleFromProject(projectInstance, projectCollection.Loggers, noLaunchProfile) is { } module)
+            if (GetModuleFromProject(projectInstance, projectCollection.Loggers, buildOptions) is { } module)
             {
                 projects.Add(new ParallelizableTestModuleGroupWithSequentialInnerModules(module));
             }
@@ -187,7 +187,7 @@ public static IEnumerable<ParallelizableTestModuleGroupWithSequentialInnerModule
                     projectInstance = EvaluateProject(projectCollection, projectFilePath, framework);
                     Logger.LogTrace(() => $"Loaded inner project '{Path.GetFileName(projectFilePath)}' has '{ProjectProperties.IsTestingPlatformApplication}' = '{projectInstance.GetPropertyValue(ProjectProperties.IsTestingPlatformApplication)}' (TFM: '{framework}').");
 
-                    if (GetModuleFromProject(projectInstance, projectCollection.Loggers, noLaunchProfile) is { } module)
+                    if (GetModuleFromProject(projectInstance, projectCollection.Loggers, buildOptions) is { } module)
                     {
                         projects.Add(new ParallelizableTestModuleGroupWithSequentialInnerModules(module));
                     }
@@ -201,7 +201,7 @@ public static IEnumerable<ParallelizableTestModuleGroupWithSequentialInnerModule
                     projectInstance = EvaluateProject(projectCollection, projectFilePath, framework);
                     Logger.LogTrace(() => $"Loaded inner project '{Path.GetFileName(projectFilePath)}' has '{ProjectProperties.IsTestingPlatformApplication}' = '{projectInstance.GetPropertyValue(ProjectProperties.IsTestingPlatformApplication)}' (TFM: '{framework}').");
 
-                    if (GetModuleFromProject(projectInstance, projectCollection.Loggers, noLaunchProfile) is { } module)
+                    if (GetModuleFromProject(projectInstance, projectCollection.Loggers, buildOptions) is { } module)
                     {
                         innerModules ??= new List<TestModule>();
                         innerModules.Add(module);
@@ -218,7 +218,7 @@ public static IEnumerable<ParallelizableTestModuleGroupWithSequentialInnerModule
         return projects;
     }
 
-    private static TestModule? GetModuleFromProject(ProjectInstance project, ICollection<ILogger>? loggers, bool noLaunchProfile)
+    private static TestModule? GetModuleFromProject(ProjectInstance project, ICollection<ILogger>? loggers, BuildOptions buildOptions)
     {
         _ = bool.TryParse(project.GetPropertyValue(ProjectProperties.IsTestProject), out bool isTestProject);
         _ = bool.TryParse(project.GetPropertyValue(ProjectProperties.IsTestingPlatformApplication), out bool isTestingPlatformApplication);
@@ -248,7 +248,7 @@ public static IEnumerable<ParallelizableTestModuleGroupWithSequentialInnerModule
         string projectFullPath = project.GetPropertyValue(ProjectProperties.ProjectFullPath);
 
         // TODO: Support --launch-profile and pass it here.
-        var launchSettings = TryGetLaunchProfileSettings(Path.GetDirectoryName(projectFullPath)!, Path.GetFileNameWithoutExtension(projectFullPath), project.GetPropertyValue(ProjectProperties.AppDesignerFolder), noLaunchProfile, profileName: null);
+        var launchSettings = TryGetLaunchProfileSettings(Path.GetDirectoryName(projectFullPath)!, Path.GetFileNameWithoutExtension(projectFullPath), project.GetPropertyValue(ProjectProperties.AppDesignerFolder), buildOptions, profileName: null);
 
         return new TestModule(runProperties, PathUtility.FixFilePath(projectFullPath), targetFramework, isTestingPlatformApplication, isTestProject, launchSettings, project.GetPropertyValue(ProjectProperties.TargetPath));
 
@@ -270,9 +270,9 @@ static RunProperties GetRunProperties(ProjectInstance project, ICollection<ILogg
         }
     }
 
-    private static ProjectLaunchSettingsModel? TryGetLaunchProfileSettings(string projectDirectory, string projectNameWithoutExtension, string appDesignerFolder, bool noLaunchProfile, string? profileName)
+    private static ProjectLaunchSettingsModel? TryGetLaunchProfileSettings(string projectDirectory, string projectNameWithoutExtension, string appDesignerFolder, BuildOptions buildOptions, string? profileName)
     {
-        if (noLaunchProfile)
+        if (buildOptions.NoLaunchProfile)
         {
             return null;
         }
@@ -299,6 +299,12 @@ static RunProperties GetRunProperties(ProjectInstance project, ICollection<ILogg
             return null;
         }
 
+        // If buildOptions.Verbosity is null, we still want to print the message.
+        if (buildOptions.Verbosity != VerbosityOptions.quiet)
+        {
+            Reporter.Output.WriteLine(string.Format(CliCommandStrings.UsingLaunchSettingsFromMessage, launchSettingsPath));
+        }
+
         var result = LaunchSettingsManager.TryApplyLaunchSettings(launchSettingsPath, profileName);
         if (!result.Success)
         {

test/dotnet.Tests/CommandTests/Test/GivenDotnetTestBuildsAndRunsTests.cs

@@ -137,7 +137,9 @@ public void RunTestProjectWithTestsAndLaunchSettings_ShouldReturnExitCodeSuccess
             if (!TestContext.IsLocalized())
             {
                 result.StdOut
-                    .Should().Contain("Test run summary: Passed!")
+                    .Should().Contain("Using launch settings from")
+                    .And.Contain(runJson ? "TestProjectWithLaunchSettings.run.json..." : $"Properties{Path.DirectorySeparatorChar}launchSettings.json...")
+                    .And.Contain("Test run summary: Passed!")
                     .And.Contain("skipped Test1")
                     .And.Contain("total: 2")
                     .And.Contain("succeeded: 1")
@@ -163,7 +165,8 @@ public void RunTestProjectWithTestsAndNoLaunchSettings_ShouldReturnExitCodeSucce
                                         TestingPlatformOptions.NoLaunchProfileOption.Name);
 
             result.StdOut.Should()
-                .Contain("FAILED to find argument from launchSettings.json");
+                .Contain("FAILED to find argument from launchSettings.json")
+                .And.NotContain("Using launch settings from");
         }
 
         [InlineData(TestingConstants.Debug)]
@@ -181,7 +184,9 @@ public void RunTestProjectWithTestsAndNoLaunchSettingsArguments_ShouldReturnExit
                                         TestingPlatformOptions.NoLaunchProfileArgumentsOption.Name, "true");
 
             result.StdOut.Should()
-                .Contain("FAILED to find argument from launchSettings.json");
+                .Contain("Using launch settings from")
+                .And.Contain($"Properties{Path.DirectorySeparatorChar}launchSettings.json...")
+                .And.Contain("FAILED to find argument from launchSettings.json");
         }
 
         [InlineData(TestingConstants.Debug)]