[main] Update dependencies from dotnet/runtime #44751

dotnet-maestro · 2024-11-08T13:45:12Z

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

Subscription: cedddd63-79f5-4e7e-6d46-08dc434c4948
Build: 20241110.2
Date Produced: November 10, 2024 3:12:18 PM UTC
Commit: 80cb4583c9079cf052e6148b51b43590771b4353
Branch: refs/heads/main

Updates:
- Microsoft.SourceBuild.Intermediate.runtime.linux-x64: from 10.0.0-alpha.1.24557.1 to 10.0.0-alpha.1.24560.2
- Microsoft.Bcl.AsyncInterfaces: from 10.0.0-alpha.1.24557.1 to 10.0.0-alpha.1.24560.2
- Microsoft.Extensions.DependencyModel: from 10.0.0-alpha.1.24557.1 to 10.0.0-alpha.1.24560.2
- Microsoft.Extensions.FileProviders.Abstractions: from 10.0.0-alpha.1.24557.1 to 10.0.0-alpha.1.24560.2
- Microsoft.Extensions.FileSystemGlobbing: from 10.0.0-alpha.1.24557.1 to 10.0.0-alpha.1.24560.2
- Microsoft.Extensions.Logging: from 10.0.0-alpha.1.24557.1 to 10.0.0-alpha.1.24560.2
- Microsoft.Extensions.Logging.Abstractions: from 10.0.0-alpha.1.24557.1 to 10.0.0-alpha.1.24560.2
- Microsoft.Extensions.Logging.Console: from 10.0.0-alpha.1.24557.1 to 10.0.0-alpha.1.24560.2
- Microsoft.NET.HostModel: from 10.0.0-alpha.1.24557.1 to 10.0.0-alpha.1.24560.2
- Microsoft.NET.ILLink.Tasks: from 10.0.0-alpha.1.24557.1 to 10.0.0-alpha.1.24560.2
- Microsoft.NETCore.App.Host.win-x64: from 10.0.0-alpha.1.24557.1 to 10.0.0-alpha.1.24560.2
- Microsoft.NETCore.App.Ref: from 10.0.0-alpha.1.24557.1 to 10.0.0-alpha.1.24560.2
- Microsoft.NETCore.App.Runtime.win-x64: from 10.0.0-alpha.1.24557.1 to 10.0.0-alpha.1.24560.2
- Microsoft.NETCore.Platforms: from 10.0.0-alpha.1.24557.1 to 10.0.0-alpha.1.24560.2
- Microsoft.Win32.SystemEvents: from 10.0.0-alpha.1.24557.1 to 10.0.0-alpha.1.24560.2
- System.CodeDom: from 10.0.0-alpha.1.24557.1 to 10.0.0-alpha.1.24560.2
- System.Composition.AttributedModel: from 10.0.0-alpha.1.24557.1 to 10.0.0-alpha.1.24560.2
- System.Composition.Convention: from 10.0.0-alpha.1.24557.1 to 10.0.0-alpha.1.24560.2
- System.Composition.Hosting: from 10.0.0-alpha.1.24557.1 to 10.0.0-alpha.1.24560.2
- System.Composition.Runtime: from 10.0.0-alpha.1.24557.1 to 10.0.0-alpha.1.24560.2
- System.Composition.TypedParts: from 10.0.0-alpha.1.24557.1 to 10.0.0-alpha.1.24560.2
- System.Configuration.ConfigurationManager: from 10.0.0-alpha.1.24557.1 to 10.0.0-alpha.1.24560.2
- System.Formats.Asn1: from 10.0.0-alpha.1.24557.1 to 10.0.0-alpha.1.24560.2
- System.IO.Hashing: from 10.0.0-alpha.1.24557.1 to 10.0.0-alpha.1.24560.2
- System.Reflection.MetadataLoadContext: from 10.0.0-alpha.1.24557.1 to 10.0.0-alpha.1.24560.2
- System.Resources.Extensions: from 10.0.0-alpha.1.24557.1 to 10.0.0-alpha.1.24560.2
- System.Security.Cryptography.Pkcs: from 10.0.0-alpha.1.24557.1 to 10.0.0-alpha.1.24560.2
- System.Security.Cryptography.ProtectedData: from 10.0.0-alpha.1.24557.1 to 10.0.0-alpha.1.24560.2
- System.Security.Cryptography.Xml: from 10.0.0-alpha.1.24557.1 to 10.0.0-alpha.1.24560.2
- System.Security.Permissions: from 10.0.0-alpha.1.24557.1 to 10.0.0-alpha.1.24560.2
- System.ServiceProcess.ServiceController: from 10.0.0-alpha.1.24557.1 to 10.0.0-alpha.1.24560.2
- System.Text.Encoding.CodePages: from 10.0.0-alpha.1.24557.1 to 10.0.0-alpha.1.24560.2
- System.Text.Json: from 10.0.0-alpha.1.24557.1 to 10.0.0-alpha.1.24560.2
- System.Windows.Extensions: from 10.0.0-alpha.1.24557.1 to 10.0.0-alpha.1.24560.2
- VS.Redist.Common.NetCore.SharedFramework.x64.10.0: from 10.0.0-alpha.1.24557.1 to 10.0.0-alpha.1.24560.2
- VS.Redist.Common.NetCore.TargetingPack.x64.10.0: from 10.0.0-alpha.1.24557.1 to 10.0.0-alpha.1.24560.2

…1108.1 Microsoft.SourceBuild.Intermediate.runtime.linux-x64 , Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Formats.Asn1 , System.IO.Hashing , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.10.0 , VS.Redist.Common.NetCore.TargetingPack.x64.10.0 From Version 10.0.0-alpha.1.24557.1 -> To Version 10.0.0-alpha.1.24558.1

dotnet-maestro · 2024-11-08T13:55:23Z

Notification for subscribed users from https://github.com/dotnet/runtime:

@dotnet/dnr-codeflow

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

This pull request contains changes from your source repo (https://github.com/dotnet/runtime) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
For more details, please read the Arcade Darc documentation

akoeplinger · 2024-11-08T17:06:33Z

two ILLink tests fail due to:

Test output contained the following extra linker warnings:

ILLink : Trim analysis warning IL2045: Internal.Runtime.InteropServices.ComActivator.BasicClassFactory.CreateValidatedInterfaceType(Type, Guid&, Object): Attribute 'System.Runtime.InteropServices.ClassInterfaceAttribute' is being referenced in code but the trimmer was instructed to remove all instances of this attribute. If the attribute instances are necessary make sure to either remove the trimmer attribute XML portion which removes the attribute instances, or override the removal by using the trimmer XML descriptor to keep the attribute type (which in turn keeps all of its instances). [C:\h\w\991C091E\t\dotnetSdkTests\svxpipfk.y4v\ILLink_verify---936B265C\AnalysisWarningsOnHelloWorldApp\AnalysisWarningsOnHelloWorldApp.csproj]

Related to dotnet/runtime#109616 /cc @AaronRobinsonMSFT

AaronRobinsonMSFT · 2024-11-08T18:52:28Z

/cc @sbomer @agocke

sbomer

The test fix LGTM to unblock flow, though it would be better to annotate the place where the attribute lookup is done in COM, as discussed. (Just to improve the warning experience for the unsupported scenario where COM support is turned on.)

test/Microsoft.NET.Publish.Tests/PublishTestUtils.cs

…1108.9 Microsoft.SourceBuild.Intermediate.runtime.linux-x64 , Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Formats.Asn1 , System.IO.Hashing , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.10.0 , VS.Redist.Common.NetCore.TargetingPack.x64.10.0 From Version 10.0.0-alpha.1.24557.1 -> To Version 10.0.0-alpha.1.24558.9

…1109.3 Microsoft.SourceBuild.Intermediate.runtime.linux-x64 , Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Formats.Asn1 , System.IO.Hashing , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.10.0 , VS.Redist.Common.NetCore.TargetingPack.x64.10.0 From Version 10.0.0-alpha.1.24557.1 -> To Version 10.0.0-alpha.1.24559.3

am11 · 2024-11-09T21:38:45Z

src/SourceBuild/patches/runtime/0001-Runtime patch to support net10.0.patch is failing to apply because dotnet/runtime#109634 was included. It's safe to delete this patch.

ViktorHofer · 2024-11-10T08:34:24Z

@jkoritzinsky PTAL (unified build runtime errors) cpio not found

am11 · 2024-11-10T10:07:29Z

I'm not 100% sure but I hope dotnet/arcade#15233 will resolve the cpio errors. Lets see. :)

akoeplinger · 2024-11-10T10:11:11Z

We just missed it in the ubuntu image: dotnet/dotnet-buildtools-prereqs-docker#1253

…1110.1 Microsoft.SourceBuild.Intermediate.runtime.linux-x64 , Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Formats.Asn1 , System.IO.Hashing , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.10.0 , VS.Redist.Common.NetCore.TargetingPack.x64.10.0 From Version 10.0.0-alpha.1.24557.1 -> To Version 10.0.0-alpha.1.24560.1

akoeplinger · 2024-11-11T10:18:12Z

the sdk-source-build job now fails because we're passing the non-portable RID into the CreateRpmPackage task:

am11 · 2024-11-11T10:38:26Z

Why https://github.com/dotnet/runtime/blob/35d27803b83bbd46d3cfe42aa58f46f585c0c6ae/src/installer/pkg/sfx/installers/dotnet-runtime-deps/Directory.Build.props#L7 isn't workng?
As a quick workaround, we could just pass -p:InstallerRuntimeIdentifier=linux-x64 from the vmr yml to get by and investigate it separately.

akoeplinger · 2024-11-11T11:02:29Z

@am11 this is building src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Ref.sfxproj so that Directory.Build.props doesn't apply

am11 · 2024-11-11T11:39:01Z

Right, we need to use the same InstallerRuntimeIdentifier=linux-{arch} there as well. You can pass it to runtime BuildArgs in this repo to unblock this PR (assuming this is the only thing blocking the flow).

akoeplinger · 2024-11-11T12:08:59Z

I've added the workaround and filed dotnet/source-build#4728, I think overriding in the runtime build is not the best long term fix since all this is really used for in the end is to decide whether to write linux or freebsd into the rpm: https://github.com/dotnet/arcade/blob/232061b49ae2157efbb83acde9acae79ef3d6d40/src/Microsoft.DotNet.Build.Tasks.Installers/src/RpmBuilder.cs#L98

src/SourceBuild/content/repo-projects/runtime.proj

…1110.2 Microsoft.SourceBuild.Intermediate.runtime.linux-x64 , Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Formats.Asn1 , System.IO.Hashing , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.10.0 , VS.Redist.Common.NetCore.TargetingPack.x64.10.0 From Version 10.0.0-alpha.1.24557.1 -> To Version 10.0.0-alpha.1.24560.2

src/SourceBuild/patches/runtime/0001-Workaround-for-CreateRpmPackage-issue.patch

This reverts commit 3500737.

ghost added Area-CodeFlow untriaged Request triage from a team member labels Nov 8, 2024

Merge branch 'main' into darc-main-83161337-3bf7-43a8-9016-55cab8098606

d398903

dotnet deleted a comment from azure-pipelines bot Nov 8, 2024

akoeplinger approved these changes Nov 8, 2024

View reviewed changes

Add expected warnings to baseline.

cd32842

AaronRobinsonMSFT requested a review from a team as a code owner November 8, 2024 18:52

sbomer approved these changes Nov 8, 2024

View reviewed changes

test/Microsoft.NET.Publish.Tests/PublishTestUtils.cs Show resolved Hide resolved

AaronRobinsonMSFT mentioned this pull request Nov 8, 2024

Update trimmer attributes for ComActivator dotnet/runtime#109655

Merged

build-analysis bot mentioned this pull request Nov 8, 2024

The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008

Open

3 tasks

build-analysis bot mentioned this pull request Nov 9, 2024

Failure on Helix tests - Tests timing out #40074

Open

Delete obsolete runtime patch

b9af68b

akoeplinger requested review from a team as code owners November 9, 2024 22:29

akoeplinger mentioned this pull request Nov 9, 2024

Exclude shared libs from ilcframework in nupkg dotnet/runtime#109253

Merged

dotnet-maestro bot and others added 2 commits November 10, 2024 13:42

Add more expected warnings, we need one entry for each warning instance

b4431fa

akoeplinger mentioned this pull request Nov 11, 2024

CreateRpmPackage is passed a non-portable RID for PackageOS in source-only builds dotnet/source-build#4728

Closed

Add workaround for CreateRpmPackage issue

ba0bf2c

am11 reviewed Nov 11, 2024

View reviewed changes

src/SourceBuild/content/repo-projects/runtime.proj Outdated Show resolved Hide resolved

akoeplinger and others added 3 commits November 11, 2024 14:25

Fix workaround

098a495

Fix patch

c721ce7

MichaelSimons reviewed Nov 11, 2024

View reviewed changes

src/SourceBuild/patches/runtime/0001-Workaround-for-CreateRpmPackage-issue.patch Outdated Show resolved Hide resolved

premun mentioned this pull request Nov 11, 2024

Revert darc version to 24367.3 #44794

Closed

premun and others added 3 commits November 11, 2024 16:14

Revert darc version to 24367.3

3500737

Revert "Revert darc version to 24367.3"

0bdc14e

This reverts commit 3500737.

Try adding workaround via env var instead

346fce8

dotnet-maestro bot merged commit 20fd01c into main Nov 11, 2024
41 checks passed

dotnet-maestro bot deleted the darc-main-83161337-3bf7-43a8-9016-55cab8098606 branch November 11, 2024 18:35

premun mentioned this pull request Nov 12, 2024

Fix VMR patch re-application dotnet/arcade-services#4144

Merged

[main] Update dependencies from dotnet/runtime #44751

[main] Update dependencies from dotnet/runtime #44751

Uh oh!

Conversation

dotnet-maestro bot commented Nov 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

From https://github.com/dotnet/runtime

Uh oh!

dotnet-maestro bot commented Nov 8, 2024

Notification for subscribed users from https://github.com/dotnet/runtime:

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

Uh oh!

akoeplinger commented Nov 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AaronRobinsonMSFT commented Nov 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sbomer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

am11 commented Nov 9, 2024

Uh oh!

ViktorHofer commented Nov 10, 2024

Uh oh!

am11 commented Nov 10, 2024

Uh oh!

akoeplinger commented Nov 10, 2024

Uh oh!

akoeplinger commented Nov 11, 2024

Uh oh!

am11 commented Nov 11, 2024

Uh oh!

akoeplinger commented Nov 11, 2024

Uh oh!

am11 commented Nov 11, 2024

Uh oh!

akoeplinger commented Nov 11, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

dotnet-maestro bot commented Nov 8, 2024 •

edited

Loading

akoeplinger commented Nov 8, 2024 •

edited

Loading

AaronRobinsonMSFT commented Nov 8, 2024 •

edited

Loading