Skip to content

Conversation

jkoritzinsky
Copy link
Member

@jkoritzinsky jkoritzinsky commented Dec 13, 2024

Contributes to dotnet/source-build#3793

TODO:

  • Treat the host-built Crossgen2 pack as a "vertical" visibility asset in the runtime build to ensure we don't accidentally ship it.
  • Put out a PR with the aspnetcore changes once this PR is working through aspnetcore.

Constituent PRs:

dotnet/runtime#110676
dotnet/aspnetcore#59551
dotnet/windowsdesktop#4815

Depends on #45553

@ghost ghost added Area-Infrastructure untriaged Request triage from a team member labels Dec 13, 2024
@jkoritzinsky
Copy link
Member Author

/azp run sdk-unified-build-full

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jkoritzinsky
Copy link
Member Author

/azp run sdk-unified-build-full

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@am11
Copy link
Member

am11 commented Dec 14, 2024

Fixes dotnet/source-build#3793

Would it also cover ILC part of the issue?

@jkoritzinsky
Copy link
Member Author

I'll alter this to "contributes to". I'm having trouble finding current use cases of ILC outside of the runtime repo for product code (other than the finalizer exe here which isn't merged in yet).

@jkoritzinsky
Copy link
Member Author

/azp run sdk-unified-build-full

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jkoritzinsky
Copy link
Member Author

/azp run sdk-unified-build-full

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jkoritzinsky
Copy link
Member Author

/azp run sdk-unified-build-full

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jkoritzinsky
Copy link
Member Author

/azp run sdk-unified-build-full

@jkoritzinsky jkoritzinsky added the Blocked Issue is blocked on an external dependency label Dec 18, 2024
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jkoritzinsky jkoritzinsky marked this pull request as ready for review December 18, 2024 23:21
@jkoritzinsky jkoritzinsky requested a review from a team as a code owner December 18, 2024 23:21
@jkoritzinsky jkoritzinsky removed the Blocked Issue is blocked on an external dependency label Dec 20, 2024
@jkoritzinsky
Copy link
Member Author

/azp run sdk-unified-build-full

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jkoritzinsky jkoritzinsky enabled auto-merge (squash) January 13, 2025 21:12
@jkoritzinsky jkoritzinsky merged commit f2a7b31 into dotnet:main Jan 13, 2025
35 of 38 checks passed
@jkoritzinsky jkoritzinsky deleted the host-crossgen2 branch January 31, 2025 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Infrastructure untriaged Request triage from a team member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants