Skip to content

Run installer tests in pipeline #47313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 21, 2025
Merged

Run installer tests in pipeline #47313

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5d3d117
Run installer tests in pipeline
NikolaMilosavljevic Mar 6, 2025
4c52a0c
Addressing comments
NikolaMilosavljevic Mar 6, 2025
1569909
Add project override
NikolaMilosavljevic Mar 7, 2025
defc5d2
Publish test results
NikolaMilosavljevic Mar 7, 2025
08f3e6b
Update search folder
NikolaMilosavljevic Mar 10, 2025
69eba5d
Merge branch 'main' into installer.test.pipeline
NikolaMilosavljevic Mar 13, 2025
6a94386
Merge branch 'main' into installer.test.pipeline
NikolaMilosavljevic Mar 13, 2025
48efb04
Merge branch 'main' into installer.test.pipeline
NikolaMilosavljevic Mar 13, 2025
5dfa459
Use --ci
NikolaMilosavljevic Mar 14, 2025
d9895e4
Few tweaks
NikolaMilosavljevic Mar 14, 2025
b85afdb
Merge branch 'main' into installer.test.pipeline
NikolaMilosavljevic Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions eng/pipelines/templates/stages/vmr-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -988,7 +988,7 @@ stages:
- job: ValidateInstallers_Linux_x64
displayName: Validate Installers - Linux x64
pool: ${{ parameters.pool_Linux }}
timeoutInMinutes: 240
timeoutInMinutes: 30
steps:
- template: ../steps/vmr-validate-installers.yml
parameters:
Expand All @@ -998,7 +998,7 @@ stages:
- job: ValidateInstallers_Linux_arm64
displayName: Validate Installers - Linux arm64
pool: ${{ parameters.pool_LinuxArm64 }}
timeoutInMinutes: 240
timeoutInMinutes: 30
steps:
- template: ../steps/vmr-validate-installers.yml
parameters:
Expand Down
4 changes: 3 additions & 1 deletion src/SourceBuild/content/test/Microsoft.DotNet.Installer.Tests/LinuxInstallerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,9 @@ public LinuxInstallerTests(ITestOutputHelper outputHelper)
_contextDir = Path.Combine(_tmpDir, Path.GetRandomFileName());
Directory.CreateDirectory(_contextDir);

_excludeLinuxArch = Config.Architecture == Architecture.X64 ? "arm64" : "x64";
_excludeLinuxArch = Config.Architecture == Architecture.X64 ?
Copy link
Member

@MichaelSimons MichaelSimons Mar 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this just be the following? Why is the condition necessary?

Suggested change
_excludeLinuxArch = Config.Architecture == Architecture.X64 ?
_excludeLinuxArch = Architecture.Arm64.ToString().ToLower()

Copy link
Member

@MichaelSimons MichaelSimons Mar 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong example... Config.Architecture.ToString().ToLower()

Copy link
Member Author

@NikolaMilosavljevic NikolaMilosavljevic Mar 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For x64 tests we exclude arm64 packages from copying to the image. For arm64 tests we exclude x64 packages.

Copy link
Member

@MichaelSimons MichaelSimons Mar 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see - taking a step back, my larger question is what will happen if/when additional architectures are added? Ideally this code would be written in a way that would be unaffected.

Copy link
Member Author

@NikolaMilosavljevic NikolaMilosavljevic Mar 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we add another supported architecture for testing, we'd need to modify this code and the Architecture enum, at the same time.

This member field as an optimization only. We could just iterate over all supported architectures that are not being tested, in the filtering method. That would incur performance cost.

Ideally, as we discussed before, I think filtering should be modified to consume the merged manifest and filter packages based on vertical name/Id. I can do a follow up PR with that change.

Copy link
Member

@MichaelSimons MichaelSimons Mar 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think filtering should be modified to consume the merged manifest and filter packages based on vertical name/Id. I can do a follow up PR with that change.

Sounds good to me.

Architecture.Arm64.ToString().ToLower() :
Architecture.X64.ToString().ToLower();
}

public void Dispose()
Expand Down