Skip to content

Fix NullReferenceException when NuGet source URLs contain leading whitespace #49315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Fix NullReferenceException when NuGet source URLs contain leading whitespace #49315

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
68eb541
Fix NullReferenceException when NuGet sources have leading whitespace
Copilot Jun 10, 2025
b14bd65
Fix whitespace trimming in ExpandLocalFeed to prevent path processing…
Copilot Jun 11, 2025
cf3d73b
Merge branch 'main' into copilot/fix-49211
akoeplinger Jun 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Cli/dotnet/NugetPackageDownloader/PackageSourceLocation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ private static string[] ExpandLocalFeed(string[] sourceFeedOverrides, string bas
string[] localFeedsThatIsRooted = new string[sourceFeedOverrides.Length];
for (int index = 0; index < sourceFeedOverrides.Length; index++)
{
string feed = sourceFeedOverrides[index];
string feed = sourceFeedOverrides[index].Trim();
if (!Uri.IsWellFormedUriString(feed, UriKind.Absolute) && !Path.IsPathRooted(feed))
{
localFeedsThatIsRooted[index] = Path.GetFullPath(feed, basePath);
Expand Down
24 changes: 24 additions & 0 deletions test/Microsoft.DotNet.PackageInstall.Tests/NuGetPackageInstallerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,17 @@ public async Task GivenASourceInstallSucceeds()
packagePath.Should().Contain(_tempDirectory.Value, "Package should be downloaded to the input folder");
}

[Fact]
public async Task GivenSourceWithLeadingWhitespaceInstallSucceeds()
{
string packagePath = await _installer.DownloadPackageAsync(
TestPackageId,
new NuGetVersion(TestPackageVersion),
new PackageSourceLocation(sourceFeedOverrides: new[] { " " + GetTestLocalFeedPath() })); // Leading space
File.Exists(packagePath).Should().BeTrue();
packagePath.Should().Contain(_tempDirectory.Value, "Package should be downloaded to the input folder");
}

[Fact]
public async Task GivenAFailedSourceItShouldError()
{
Expand Down Expand Up @@ -228,6 +239,19 @@ public async Task WhenPassedIncludePreviewItInstallSucceeds()
"Package should download higher package version");
}

[Fact]
public async Task GivenAdditionalSourceWithLeadingWhitespaceInstallSucceeds()
{
string getTestLocalFeedPath = GetTestLocalFeedPath();
string relativePath = Path.GetRelativePath(Environment.CurrentDirectory, getTestLocalFeedPath);
string packagePath = await _installer.DownloadPackageAsync(
TestPackageId,
new NuGetVersion(TestPackageVersion),
new PackageSourceLocation(additionalSourceFeeds: new[] { " " + relativePath })); // Leading space
File.Exists(packagePath).Should().BeTrue();
packagePath.Should().Contain(_tempDirectory.Value, "Package should be downloaded to the input folder");
}

[WindowsOnlyFact]
public async Task GivenANonSignedSdkItShouldPrintMessageOnce()
{
Expand Down