Include localPath in deps.json for runtime assets #50120
Draft
+487
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on DestinationSubDirectory
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include
localPathproperty in deps.json for runtime assetsDestinationSubDirectorymetadata + file nameRuntimeFileandResourceAssemblyconstructors that take a local pathThe tests in
GivenThatWeWantToBuildANetCoreAppvalidate the generated .deps.json and the current behaviour when running the produced output. Until the runtime change to actually use thelocalPathproperty gets in and over to the sdk repo, putting dependencies in custom subdirectories will fail at run time.Resolves #48406
Needs #50073 for the updated
Microsoft.Extensions.DependencyModel