-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add test for MTP test app with empty entry-point that doesn't handshake with dotnet test #50131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+63
−0
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
11 changes: 11 additions & 0 deletions
11
test/TestAssets/TestProjects/ConsoleAppDoesNothing/ConsoleAppDoesNothing.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
<Project Sdk="Microsoft.NET.Sdk"> | ||
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), testAsset.props))\testAsset.props" /> | ||
|
||
<PropertyGroup> | ||
<TargetFramework>$(CurrentTargetFramework)</TargetFramework> | ||
<OutputType>Exe</OutputType> | ||
<ManagePackageVersionsCentrally>false</ManagePackageVersionsCentrally> | ||
<IsTestingPlatformApplication>true</IsTestingPlatformApplication> | ||
</PropertyGroup> | ||
|
||
</Project> |
17 changes: 17 additions & 0 deletions
17
test/TestAssets/TestProjects/ConsoleAppDoesNothing/Program.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
// Licensed to the .NET Foundation under one or more agreements. | ||
// The .NET Foundation licenses this file to you under the MIT license. | ||
|
||
namespace ConsoleAppDoesNothing; | ||
|
||
public class Program | ||
{ | ||
/// <summary> | ||
/// A console application that does "nothing" - just exits without any handshake or testing platform interaction. | ||
/// This is used to test dotnet test behavior with non-MTP console applications. | ||
/// </summary> | ||
public static void Main(string[] args) | ||
{ | ||
// Intentionally does nothing - no handshake, no test framework, just exits | ||
// This simulates a regular console app that doesn't implement MTP protocol | ||
} | ||
} |
2 changes: 2 additions & 0 deletions
2
test/TestAssets/TestProjects/ConsoleAppDoesNothing/dotnet.config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
[dotnet.test.runner] | ||
name = "Microsoft.Testing.Platform" |
33 changes: 33 additions & 0 deletions
33
test/dotnet.Tests/CommandTests/Test/GivenDotnetTestRunsConsoleAppWithoutHandshake.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
// Licensed to the .NET Foundation under one or more agreements. | ||
// The .NET Foundation licenses this file to you under the MIT license. | ||
|
||
using Microsoft.DotNet.Cli.Commands.Test; | ||
using CommandResult = Microsoft.DotNet.Cli.Utils.CommandResult; | ||
using ExitCodes = Microsoft.NET.TestFramework.ExitCode; | ||
|
||
namespace Microsoft.DotNet.Cli.Test.Tests | ||
{ | ||
public class GivenDotnetTestRunsConsoleAppWithoutHandshake : SdkTest | ||
{ | ||
public GivenDotnetTestRunsConsoleAppWithoutHandshake(ITestOutputHelper log) : base(log) | ||
{ | ||
} | ||
|
||
[InlineData(TestingConstants.Debug)] | ||
[InlineData(TestingConstants.Release)] | ||
[Theory] | ||
public void RunConsoleAppDoesNothing_ShouldReturnCorrectExitCode(string configuration) | ||
{ | ||
// This test validates the behavior when running `dotnet test` against a console application | ||
// that does "nothing" and doesn't handshake with us. | ||
TestAsset testInstance = _testAssetsManager.CopyTestAsset("ConsoleAppDoesNothing", Guid.NewGuid().ToString()) | ||
.WithSource(); | ||
|
||
CommandResult result = new DotnetTestCommand(Log, disableNewOutput: false) | ||
.WithWorkingDirectory(testInstance.Path) | ||
.Execute(TestingPlatformOptions.ConfigurationOption.Name, configuration); | ||
|
||
result.ExitCode.Should().Be(ExitCodes.GenericFailure, "dotnet test should fail with a meaningful error when run against console app without MTP handshake"); | ||
} | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.