Skip to content

Clarify assertion message in a run-file test #50169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 13, 2025
Merged

Clarify assertion message in a run-file test #50169

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4ab651
Clarify assertion message in a run-file test
jjonescz Aug 11, 2025
1328812
Add missing parenthesis
jjonescz Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/dotnet.Tests/CommandTests/Run/RunFileTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2090,7 +2090,7 @@ public static IEnumerable<string> GetPathsOfCscInputsFromNuGetCache()
{
Log.WriteLine($"{codeFilePath.FullName} needs to be updated:");
Log.WriteLine(newText);
if (Environment.GetEnvironmentVariable("CI") == "true")
if (Env.GetEnvironmentVariableAsBool("CI"))
{
throw new InvalidOperationException($"Not updating file in CI: {codeFilePath.FullName}");
}
Expand Down Expand Up @@ -2217,7 +2217,7 @@ Hello from {programName}
var msbuildFileText = File.ReadAllText(msbuildFile);
if (cscOnlyFileText.ReplaceLineEndings() != msbuildFileText.ReplaceLineEndings())
{
Log.WriteLine($"File differs between MSBuild and CSC-only runs: {cscOnlyFile}");
Log.WriteLine($"File differs between MSBuild and CSC-only runs (if this is expected, find the template in '{nameof(CSharpCompilerCommand)}.cs' and update it: {cscOnlyFile}");
const int limit = 3_000;
if (cscOnlyFileText.Length < limit && msbuildFileText.Length < limit)
{
Expand Down
Loading